Skip to content

Commit 73b376a

Browse files
authored
[Chore] Remove stray mod tap interrupt defines and per key functions (qmk#20347)
* Remove stray defines and per key functions * Remove defunct get_ignore_mod_tap_interrupt declaration
1 parent 7115927 commit 73b376a

File tree

7 files changed

+5
-44
lines changed

7 files changed

+5
-44
lines changed

docs/zh-cn/mod_tap.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
117117
}
118118
```
119119
120-
在数字及字母键上使用Mod-Tap时推荐启用 `IGNORE_MOD_TAP_INTERRUPT`,以避免在快速按下下一个键时保持功能优先级。参见[忽略Mod Tap中断](zh-cn/tap_hold.md#ignore-mod-tap-interrupt)。
121-
122120
### 同时改变点击和按住功能
123121
124122
最后一个例子通过 `LT(0,KC_NO)` 实现了点击复制,按住粘贴的功能:

keyboards/crkbd/keymaps/cameronjlarsen/config.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#define TAPPING_FORCE_HOLD
2626
#define TAPPING_TERM 135
2727

28-
#define IGNORE_MOD_TAP_INTERRUPT
2928
#define CAPS_WORD_IDLE_TIMEOUT 5000 // Turn off Caps Word after 5 seconds.
3029

3130
#ifdef RGBLIGHT_ENABLE

keyboards/handwired/stef9998/split_5x7/keymaps/stef9998/keymap.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,20 @@ enum custom_keycodes {
3939
// Shortcut to make keymap more readable
4040
#define KC_FN MO(_FN)
4141

42-
bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
42+
bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
4343
switch (keycode) {
4444
case SC_LSPO:
4545
// Do not force the mod-tap key press to be handled as a modifier
4646
// if any other key was pressed while the mod-tap key is held down.
47-
return false;
47+
return true;
4848
// case MT(MOD_LSFT,KC_9):
4949
// return false;
5050
case SC_RSPC:
51-
return false;
51+
return true;
5252
default:
5353
// Force the mod-tap key press to be handled as a modifier if any
5454
// other key was pressed while the mod-tap key is held down.
55-
return true;
55+
return false;
5656
}
5757
}
5858

@@ -185,4 +185,4 @@ _______ ,_______ ,RALT_T(KC_S),LCTL_T(KC_D),LSFT_T(KC_F),LT(_SYM,KC_G),_______ ,
185185
_______ ,_______ ,_______ ,_______ ,_______ ,_______ , _______ ,_______ ,_______ ,_______ ,_______ ,_______
186186
// └────────┴────────┴──────────┴──────────┴─────────────┴────────┘ └────────┴─────────────┴──────────┴──────────┴────────┴────────┘
187187
),
188-
*/
188+
*/

keyboards/karn/keymaps/colemak/keymap.c

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -27,37 +27,6 @@ bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
2727
}
2828
}
2929

30-
bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
31-
switch (keycode) {
32-
case CTL_T(KC_X):
33-
return true;
34-
case ALT_T(KC_C):
35-
return true;
36-
case CMD_T(KC_V):
37-
return true;
38-
case CMD_T(KC_M):
39-
return true;
40-
case ALT_T(KC_COMM):
41-
return true;
42-
case CTL_T(KC_DOT):
43-
return true;
44-
case KC_X:
45-
return true;
46-
case KC_C:
47-
return true;
48-
case KC_V:
49-
return true;
50-
case KC_M:
51-
return true;
52-
case KC_COMM:
53-
return true;
54-
case KC_DOT:
55-
return true;
56-
default:
57-
return false;
58-
}
59-
}
60-
6130
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
6231

6332

@@ -93,4 +62,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
9362
_______, _______, _______, _______, _______, _______
9463
)
9564
};
96-

keyboards/splitkb/aurora/sweep/keymaps/default/keymap.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
"tapping": {
8080
"term": 200,
8181
"permissive_hold": true,
82-
"ignore_mod_tap_interrupt": true,
8382
"force_hold": true
8483
}
8584
}

keyboards/splitkb/kyria/keymaps/cameronjlarsen/config.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
# define RGBLIGHT_LIMIT_VAL 150
3434
#endif
3535

36-
// Lets you roll mod-tap keys
37-
#define IGNORE_MOD_TAP_INTERRUPT
3836
// Enable rapid switch from tap to hold, disables double tap hold auto-repeat.
3937
#define TAPPING_FORCE_HOLD
4038
// Configure the global tapping term (default: 200ms)

quantum/action_tapping.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ void action_tapping_process(keyrecord_t record);
4343
uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record);
4444
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record);
4545
bool get_permissive_hold(uint16_t keycode, keyrecord_t *record);
46-
bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record);
4746
bool get_retro_tapping(uint16_t keycode, keyrecord_t *record);
4847
bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record);
4948

0 commit comments

Comments
 (0)