Fix E2E Test Errors (#2405)

# Goal
The goal of this PR is to make the e2e tests work against Testnet on
Paseo

e2e Run against Testnet-Paseo:
https://github.com/frequency-chain/frequency/actions/runs/15022918786

All green except for non-released features!

# Discussion

The main issue is that many things need to wait until finalization for
the next thing to be able to consistently work.

- Updated JS packages
- Split up several e2e tests to parallelize
- Update the setup of many e2e tests to run in parallel
- Update the nonce setup to use Atomics so that it is "thread" safe
- Increase timeouts as the tests take longer against a chain that takes
time to finalize
- Suppress expected rpc errors on sendUnsigned

Author: wilwade

e2e/.mocharc.json

@@ -1,5 +1,6 @@
 {
   "exit": true,
+  "fullTrace": true,
   "extension": ["ts"],
   "parallel": true,
   "require": ["scaffolding/globalHooks.ts", "scaffolding/rootHooks.ts", "scaffolding/extrinsicHelpers.ts"],

e2e/.relay-chain-all.mocharc.json

@@ -1,9 +1,10 @@
 {
   "exit": true,
+  "fullTrace": true,
   "extension": ["ts"],
   "parallel": true,
   "require": ["scaffolding/globalHooks.ts", "scaffolding/rootHooks.ts", "scaffolding/extrinsicHelpers.ts"],
   "import": "tsx/esm",
   "spec": ["./{,!(node_modules|load-tests)/**}/*.test.ts"],
-  "timeout": 180000
+  "timeout": 300000
 }

e2e/.relay-chain.mocharc.json

@@ -1,7 +1,8 @@
 {
   "exit": true,
+  "fullTrace": true,
   "extension": ["ts"],
   "require": ["scaffolding/rootHooks.ts", "scaffolding/extrinsicHelpers.ts"],
   "import": "tsx/esm",
-  "timeout": 180000
+  "timeout": 300000
 }

e2e/README.md

@@ -17,6 +17,21 @@ Note: this is for the "createMsa" tests
 
 See below for running load tests and relay chain tests.
 
+Waiting for Finalization
+============================
+
+Some actions require waiting for finalization before the next action can happen.
+
+Example: Funding a key that will then take an action that uses that funding.
+
+While sometimes this is not needed, it creates a race condition and sometimes the transaction pool will reject the
+second transaction as it is unfunded.
+
+The transaction pool doesn't know when two transactions are dependent if they are not from the same account with the
+same nonce.
+
+Make sure to wait for finalization before attempting the next dependent transaction.
+
 Notes on E2E Testing
 ============================
 

e2e/capacity/capacityFail.test.ts

@@ -160,7 +160,13 @@ describe('Capacity Transaction Failures', function () {
       // from the transaction pool.
       it('fails to pay for a transaction with empty capacity', async function () {
         const noCapacityKeys = createKeys('noCapacityKeys');
-        const noCapacityProvider = await createMsaAndProvider(fundingSource, noCapacityKeys, 'NoCapProvider');
+        const noCapacityProvider = await createMsaAndProvider(
+          fundingSource,
+          noCapacityKeys,
+          'NoCapProvider',
+          undefined,
+          false
+        );
 
         const delegatorKeys = createKeys('delegatorKeys');
 

e2e/capacity/change_staking_target.test.ts

@@ -15,16 +15,21 @@ const fundingSource = getFundingSource(import.meta.url);
 
 describe('Capacity: change_staking_target', function () {
   const tokenMinStake: bigint = 1n * CENTS;
-  const capacityMin: bigint = tokenMinStake / 50n;
 
   it('successfully stake tokens to a provider', async function () {
     const providerBalance = 2n * DOLLARS;
     const stakeKeys = createKeys('staker');
-    const oldProvider = await createMsaAndProvider(fundingSource, stakeKeys, 'Provider1', providerBalance);
-    const [_bar, newProvider] = await createProviderKeysAndId(fundingSource, providerBalance);
 
+    // Setup
+    const [oldProvider, [_bar, newProvider]] = await Promise.all([
+      createMsaAndProvider(fundingSource, stakeKeys, 'Provider1', providerBalance),
+      createProviderKeysAndId(fundingSource, providerBalance),
+    ]);
+
+    // Stake
     await assert.doesNotReject(stakeToProvider(fundingSource, stakeKeys, oldProvider, tokenMinStake * 3n));
 
+    // Change Stake
     const call = ExtrinsicHelper.changeStakingTarget(stakeKeys, oldProvider, newProvider, tokenMinStake);
     const events = await call.signAndSend();
     assert.notEqual(events, undefined);

e2e/capacity/staking.test.ts

@@ -326,10 +326,12 @@ describe('Capacity Staking Tests', function () {
 
       const vestedTransferTx = ExtrinsicHelper.timeReleaseTransfer(fundingSource, vesterKeys, schedule);
 
-      await assert.doesNotReject(vestedTransferTx.signAndSend());
+      await assert.doesNotReject(vestedTransferTx.signAndSend(undefined, undefined, false));
       await assertFrozen(vesterKeys, 100n * DOLLARS);
 
-      await assert.doesNotReject(ExtrinsicHelper.stake(vesterKeys, providerId, 80n * DOLLARS).signAndSend());
+      await assert.doesNotReject(
+        ExtrinsicHelper.stake(vesterKeys, providerId, 80n * DOLLARS).signAndSend(undefined, undefined, false)
+      );
 
       const spendable = await getSpendableBalance(vesterKeys);
       // after txn fees

e2e/capacity/transactions.test.ts

@@ -181,7 +181,8 @@ describe('Capacity Transactions', function () {
 
           const { eventMap } = await call.payWithCapacity();
           assertEvent(eventMap, 'capacity.CapacityWithdrawn');
-          assertEvent(eventMap, 'messages.MessagesInBlock');
+          // messages.MessagesInBlock in block might not be on this transaction if there are others
+          assertEvent(eventMap, 'system.ExtrinsicSuccess');
         });
 
         it('successfully pays with Capacity for eligible transaction - addOnchainMessage', async function () {
@@ -190,7 +191,8 @@ describe('Capacity Transactions', function () {
           const call = ExtrinsicHelper.addOnChainMessage(capacityKeys, dummySchemaId, '0xdeadbeef');
           const { eventMap } = await call.payWithCapacity();
           assertEvent(eventMap, 'capacity.CapacityWithdrawn');
-          assertEvent(eventMap, 'messages.MessagesInBlock');
+          // messages.MessagesInBlock in block might not be on this transaction if there are others
+          assertEvent(eventMap, 'system.ExtrinsicSuccess');
           const get = await ExtrinsicHelper.apiPromise.rpc.messages.getBySchemaId(dummySchemaId, {
             from_block: starting_block,
             from_index: 0,

e2e/eslint.config.mjs

@@ -3,27 +3,13 @@
 import eslint from '@eslint/js';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
-import mocha from 'eslint-plugin-mocha';
-
-// Needed for eslint 9
-const mochaConfig = [
-  {
-    name: 'mocha/recommended',
-    languageOptions: {
-      globals: globals.mocha,
-    },
-    plugins: {
-      mocha,
-    },
-    rules: mocha.configs.flat.recommended.rules,
-  },
-];
+import mochaPlugin from 'eslint-plugin-mocha';
 
 export default tseslint.config(
   eslint.configs.recommended,
+  mochaPlugin.configs.recommended,
   ...tseslint.configs.strict,
   ...tseslint.configs.stylistic,
-  ...mochaConfig,
   {
     ignores: ['dist/'],
   },