Skip to content

Commit 7995508

Browse files
smozhaiskyi-rubiSerhii Mozhaiskyi
andauthored
fix handling of default settings for rubiconBidAdapter (prebid#11114)
Co-authored-by: Serhii Mozhaiskyi <[email protected]>
1 parent 8cce0b8 commit 7995508

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

modules/rubiconBidAdapter.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -829,20 +829,27 @@ function renderBid(bid) {
829829
hideSmartAdServerIframe(adUnitElement);
830830

831831
// configure renderer
832-
const config = bid.renderer.getConfig();
832+
const defaultConfig = {
833+
align: 'center',
834+
position: 'append',
835+
closeButton: false,
836+
label: undefined,
837+
collapse: true
838+
};
839+
const config = { ...defaultConfig, ...bid.renderer.getConfig() };
833840
bid.renderer.push(() => {
834841
window.MagniteApex.renderAd({
835842
width: bid.width,
836843
height: bid.height,
837844
vastUrl: bid.vastUrl,
838845
placement: {
839846
attachTo: adUnitElement,
840-
align: config.align || 'center',
841-
position: config.position || 'append'
847+
align: config.align,
848+
position: config.position
842849
},
843-
closeButton: config.closeButton || false,
844-
label: config.label || undefined,
845-
collapse: config.collapse || true
850+
closeButton: config.closeButton,
851+
label: config.label,
852+
collapse: config.collapse
846853
});
847854
});
848855
}

test/spec/modules/rubiconBidAdapter_spec.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3899,7 +3899,8 @@ describe('the rubicon adapter', function () {
38993899
config.setConfig({rubicon: {
39003900
rendererConfig: {
39013901
align: 'left',
3902-
closeButton: true
3902+
closeButton: true,
3903+
collapse: false
39033904
},
39043905
rendererUrl: 'https://example.test/renderer.js'
39053906
}});
@@ -3971,7 +3972,8 @@ describe('the rubicon adapter', function () {
39713972
expect(typeof bids[0].renderer).to.equal('object');
39723973
expect(bids[0].renderer.getConfig()).to.deep.equal({
39733974
align: 'left',
3974-
closeButton: true
3975+
closeButton: true,
3976+
collapse: false
39753977
});
39763978
expect(bids[0].renderer.url).to.equal('https://example.test/renderer.js');
39773979
});
@@ -4025,7 +4027,7 @@ describe('the rubicon adapter', function () {
40254027
const renderCall = window.MagniteApex.renderAd.getCall(0);
40264028
expect(renderCall.args[0]).to.deep.equal({
40274029
closeButton: true,
4028-
collapse: true,
4030+
collapse: false,
40294031
height: 320,
40304032
label: undefined,
40314033
placement: {
@@ -4094,7 +4096,7 @@ describe('the rubicon adapter', function () {
40944096
const renderCall = window.MagniteApex.renderAd.getCall(0);
40954097
expect(renderCall.args[0]).to.deep.equal({
40964098
closeButton: true,
4097-
collapse: true,
4099+
collapse: false,
40984100
height: 480,
40994101
label: undefined,
41004102
placement: {

0 commit comments

Comments
 (0)