Merge pull request #5608 from freedomofpress/alembic_migration_fix_due_to_sqlite_upgrade

Fixes #5605 alembic migration errors on Focal

Author: rmol

securedrop/alembic/versions/2d0ce3ee5bdc_added_passphrase_hash_column_to_.py

@@ -23,7 +23,8 @@ def upgrade():
 def downgrade():
     # sqlite has no `drop column` command, so we recreate the original table
     # then load it from a temp table
-
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     op.rename_table("journalists", "journalists_tmp")
 
     op.create_table(
@@ -43,7 +44,6 @@ def downgrade():
         sa.UniqueConstraint("username"),
     )
 
-    conn = op.get_bind()
     conn.execute(
         """
         INSERT INTO journalists

securedrop/alembic/versions/3d91d6948753_create_source_uuid_column.py

@@ -18,14 +18,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Schema migration
     op.rename_table("sources", "sources_tmp")
 
     # Add UUID column.
     op.add_column("sources_tmp", sa.Column("uuid", sa.String(length=36)))
 
     # Add UUIDs to sources_tmp table.
-    conn = op.get_bind()
     sources = conn.execute(sa.text("SELECT * FROM sources_tmp")).fetchall()
 
     for source in sources:

securedrop/alembic/versions/60f41bb14d98_add_session_nonce_to_journalist.py

@@ -17,14 +17,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Save existing journalist table.
     op.rename_table('journalists', 'journalists_tmp')
 
     # Add nonce column.
     op.add_column('journalists_tmp', sa.Column('session_nonce', sa.Integer()))
 
     # Populate nonce column.
-    conn = op.get_bind()
     journalists = conn.execute(
         sa.text("SELECT * FROM journalists_tmp")).fetchall()
 
@@ -57,7 +58,6 @@ def upgrade():
         sa.UniqueConstraint('uuid')
     )
 
-    conn = op.get_bind()
     conn.execute('''
         INSERT INTO journalists
         SELECT id, uuid, username, first_name, last_name, pw_salt, pw_hash,

securedrop/alembic/versions/6db892e17271_add_reply_uuid.py

@@ -18,14 +18,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Schema migration
     op.rename_table("replies", "replies_tmp")
 
     # Add new column.
     op.add_column("replies_tmp", sa.Column("uuid", sa.String(length=36)))
 
     # Populate new column in replies_tmp table.
-    conn = op.get_bind()
     replies = conn.execute(sa.text("SELECT * FROM replies_tmp")).fetchall()
 
     for reply in replies:

securedrop/alembic/versions/e0a525cbab83_add_column_to_track_source_deletion_of_.py

@@ -17,14 +17,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Schema migration
     op.rename_table("replies", "replies_tmp")
 
     # Add new column.
     op.add_column("replies_tmp", sa.Column("deleted_by_source", sa.Boolean()))
 
     # Populate deleted_by_source column in replies_tmp table.
-    conn = op.get_bind()
     replies = conn.execute(sa.text("SELECT * FROM replies_tmp")).fetchall()
 
     for reply in replies:

securedrop/alembic/versions/f2833ac34bb6_add_uuid_column_for_users_table.py

@@ -18,14 +18,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Save existing journalist table.
     op.rename_table("journalists", "journalists_tmp")
 
     # Add UUID column.
     op.add_column("journalists_tmp", sa.Column("uuid", sa.String(length=36)))
 
     # Add UUIDs to journalists_tmp table.
-    conn = op.get_bind()
     journalists = conn.execute(sa.text("SELECT * FROM journalists_tmp")).fetchall()
 
     for journalist in journalists:
@@ -57,7 +58,6 @@ def upgrade():
         sa.UniqueConstraint("uuid"),
     )
 
-    conn = op.get_bind()
     conn.execute(
         """
         INSERT INTO journalists

securedrop/alembic/versions/fccf57ceef02_create_submission_uuid_column.py

@@ -18,14 +18,15 @@
 
 
 def upgrade():
+    conn = op.get_bind()
+    conn.execute("PRAGMA legacy_alter_table=ON")
     # Schema migration
     op.rename_table("submissions", "submissions_tmp")
 
     # Add UUID column.
     op.add_column("submissions_tmp", sa.Column("uuid", sa.String(length=36)))
 
     # Add UUIDs to submissions_tmp table.
-    conn = op.get_bind()
     submissions = conn.execute(sa.text("SELECT * FROM submissions_tmp")).fetchall()
 
     for submission in submissions: