Merge branch 'main' into feature/addChecksumParam

Author: darwin2k

.github/dependabot.yml

@@ -0,0 +1,11 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "npm" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,72 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "main" ]
+  schedule:
+    - cron: '25 2 * * 5'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v2
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        
+        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        # queries: security-extended,security-and-quality
+
+        
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v2
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
+    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+    # - run: |
+    #   echo "Run, Build Application using script"
+    #   ./location_of_script_within_repo/buildscript.sh
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2

README.md

@@ -1,7 +1,6 @@
-
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-
-
+![Build Status](https://github.com/frankely/vin-decoder/actions/workflows/node.js.yml/badge.svg)
+![NPM Status](https://github.com/frankely/vin-decoder/actions/workflows/npm-publish.yml/badge.svg)
 
 # Vehicle Identification Number Decoder
 VIN Decoder
@@ -71,4 +70,4 @@ const serialNumber = decode('1NXBR32E77Z923602').serialNumber // 923602
 **Manufacturer**
 ```javascript
 const serialNumber = decode('1NXBR32E77Z923602').manufacturer // NUMMI USA
-```
+```

index.js

@@ -11,6 +11,7 @@ const validate =  (vin, checksumParam) => {
   //  use 9th character when checksumParam is not set
   const checksum = checksumParam || splitVIN[8]
 
+
   let total = 0;
 
   for (let i = 0; i < splitVIN.length; i++) {
@@ -133,19 +134,21 @@ const validate =  (vin, checksumParam) => {
     splitVIN.splice(i, 1, numValue * weight);
   }
 
+
   for (const element of splitVIN) {
     total += element;
   }
 
   const lastFiveChars = splitVIN.splice(0, 12);
-  
   for (const element of lastFiveChars) {
+
     if (!Number.isInteger(parseInt(element))) {
       return false;
     }
   }
-
+  
   if ((total % 11 === parseInt(checksum) || total % 11 === 10 && checksum === "x") ) {
+
     return true;
   } else {
     return false;