Skip to content

Automatically scroll to the last comment in some links #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannes-io opened this issue Mar 22, 2025 · 1 comment
Open

Automatically scroll to the last comment in some links #73

jannes-io opened this issue Mar 22, 2025 · 1 comment

Comments

@jannes-io
Copy link
Contributor

jannes-io commented Mar 22, 2025

What problem would you like to solve?
When going to a topic from notifications, email, or the "last comment by" on the forum overview, you should automatically go to the last page of comments in the topic, and the last comment should be scrolled into view.

Additional context
We already have the lastPageFirst property that allows us to go to the last page, we just need to expose this through the url and scroll the comment into view.

Then in the following places, use the new parameter:

  • In new comment emails
  • In the notifications (I think this is the same link as the email?)
  • In the "last comment by" on the forum
  • After creating a new comment
@jannes-io
Copy link
Contributor Author

jannes-io commented Mar 23, 2025

Pages where the comment list isn't the only list on the page are now also affected, since the url params are global and every abstract list uses the same param names...

So a possible solution was to add a prefix to those lists where it mattered. But we can't add prefixes, we can only override the entire query. Fixing this would require us to implement the modifier on every component individually instead of keeping it all to the AbstractList. An issue was created in symfony ux that would simplify this a lot: symfony/ux#2650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant