Skip to content

[Dropdown] submenu is positioned incorrectly within an upward pointing dropdown #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maksis opened this issue Nov 14, 2024 · 3 comments
Assignees
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@maksis
Copy link

maksis commented Nov 14, 2024

Bug Report

The submenu is positioned above the trigger item.

The submenu seems to inherit bottom: 100% !important; from the upward pointing menu. The position can be corrected by ensuring that the usual bottom: 0px !important; is applied for the submenu.

Steps to reproduce

Create an upward pointing dropdown that has a submenu

Testcase

https://jsfiddle.net/maksis/chxjws61

Screenshot (if possible)

image

Version

2.9.3

@maksis maksis added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Nov 14, 2024
@maksis maksis changed the title [Dropdown] submenu is positioned incorrectly within an upward pointing dropdwn [Dropdown] submenu is positioned incorrectly within an upward pointing dropdown Nov 14, 2024
@lubber-de lubber-de self-assigned this Nov 18, 2024
@lubber-de lubber-de removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label Nov 18, 2024
@BrianJavier99
Copy link
Contributor

BrianJavier99 commented Mar 6, 2025

Image

Source: https://fomantic-ui.com/modules/dropdown.html#pointing

Just adding here what a submenu in downward pointing dropdown looks like. As you can see the submenu should still horizontally overlap. Only the vertical alignment should be fixed.

EDIT: Issue is also directly replicable in the docs:

Image

@BrianJavier99
Copy link
Contributor

Hello again, I have tried fixing this issue. Please see my PR #3196 and let me know if you have any concerns. Thanks.

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/awaiting-investigation Anything which needs more investigation labels Mar 7, 2025
@lubber-de lubber-de added this to the 2.10.0 milestone Mar 7, 2025
@lubber-de
Copy link
Member

@BrianJavier99 Thanks! Great find and already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants