Skip to content

Commit e7de6a5

Browse files
authored
feat(dropdown): new default showonfocus false
As proposed in #1745 (reply in thread) this PR changes the default value for showOnFocus to false. This will stop the dropdown from opening but allowing it to retain focus and would be better in terms of accessibility (in a manner of speaking) I don't believe tags normally open when they gain focus (at least with autofocus) anyway (only when the enter key is hit does it open) and using the arrow keys goes through the options without it opening at all. Of course if it is clicked or tapped on, it should open... As this is a breaking change it is supposed to be part of 2.9
1 parent a254f59 commit e7de6a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/definitions/modules/dropdown.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4005,7 +4005,7 @@ $.fn.dropdown.settings = {
40054005
useLabels : true, // whether multiple select should filter currently active selections from choices
40064006
delimiter : ',', // when multiselect uses normal <input> the values will be delimited with this character
40074007

4008-
showOnFocus : true, // show menu on focus
4008+
showOnFocus : false, // show menu on focus
40094009
allowReselection : false, // whether current value should trigger callbacks when reselected
40104010
allowTab : true, // add tabindex to element
40114011
allowCategorySelection : false, // allow elements with sub-menus to be selected

0 commit comments

Comments
 (0)