Skip to content

Commit e658be3

Browse files
mvorisekmvorisek
authored
feat(lint): use Date.now() instead of new Date().getTime()
Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing unicorn/prefer-date-now rule.
1 parent b0f8d19 commit e658be3

26 files changed

+53
-54
lines changed

‎.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ module.exports = {
146146
'unicorn/no-useless-switch-case': 'off',
147147
'unicorn/no-useless-undefined': 'off',
148148
'unicorn/prefer-array-find': 'off',
149-
'unicorn/prefer-date-now': 'off',
150149
'unicorn/prefer-default-parameters': 'off',
151150
'unicorn/prefer-logical-operator-over-ternary': 'off',
152151
'unicorn/prefer-native-coercion-functions': 'off',

‎src/definitions/behaviors/api.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
? $(window)
3131
: $(this),
3232
moduleSelector = $allModules.selector || '',
33-
time = new Date().getTime(),
33+
time = Date.now(),
3434
performance = [],
3535

3636
query = arguments[0],
@@ -537,7 +537,7 @@
537537
done: function (response, textStatus, xhr) {
538538
var
539539
context = this,
540-
elapsedTime = (new Date().getTime() - requestStartTime),
540+
elapsedTime = (Date.now() - requestStartTime),
541541
timeLeft = (settings.loadingDuration - elapsedTime),
542542
translatedResponse = (isFunction(settings.onResponse))
543543
? module.is.expectingJSON() && !settings.rawResponse
@@ -566,7 +566,7 @@
566566
fail: function (xhr, status, httpMessage) {
567567
var
568568
context = this,
569-
elapsedTime = (new Date().getTime() - requestStartTime),
569+
elapsedTime = (Date.now() - requestStartTime),
570570
timeLeft = (settings.loadingDuration - elapsedTime)
571571
;
572572
timeLeft = (timeLeft > 0)
@@ -727,7 +727,7 @@
727727
loading: function () {
728728
module.verbose('Adding loading state to element', $context);
729729
$context.addClass(className.loading);
730-
requestStartTime = new Date().getTime();
730+
requestStartTime = Date.now();
731731
},
732732
},
733733

@@ -949,7 +949,7 @@
949949
previousTime
950950
;
951951
if (settings.performance) {
952-
currentTime = new Date().getTime();
952+
currentTime = Date.now();
953953
previousTime = time || currentTime;
954954
executionTime = currentTime - previousTime;
955955
time = currentTime;

‎src/definitions/behaviors/form.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
$allModules = $(this),
2525
moduleSelector = $allModules.selector || '',
2626

27-
time = new Date().getTime(),
27+
time = Date.now(),
2828
performance = [],
2929

3030
query = arguments[0],
@@ -1382,7 +1382,7 @@
13821382
previousTime
13831383
;
13841384
if (settings.performance) {
1385-
currentTime = new Date().getTime();
1385+
currentTime = Date.now();
13861386
previousTime = time || currentTime;
13871387
executionTime = currentTime - previousTime;
13881388
time = currentTime;

‎src/definitions/behaviors/state.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
moduleSelector = $allModules.selector || '',
2727

28-
time = new Date().getTime(),
28+
time = Date.now(),
2929
performance = [],
3030

3131
query = arguments[0],
@@ -464,7 +464,7 @@
464464
previousTime
465465
;
466466
if (settings.performance) {
467-
currentTime = new Date().getTime();
467+
currentTime = Date.now();
468468
previousTime = time || currentTime;
469469
executionTime = currentTime - previousTime;
470470
time = currentTime;

‎src/definitions/behaviors/visibility.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
$allModules = $(this),
2525
moduleSelector = $allModules.selector || '',
2626

27-
time = new Date().getTime(),
27+
time = Date.now(),
2828
performance = [],
2929

3030
query = arguments[0],
@@ -1072,7 +1072,7 @@
10721072
previousTime
10731073
;
10741074
if (settings.performance) {
1075-
currentTime = new Date().getTime();
1075+
currentTime = Date.now();
10761076
previousTime = time || currentTime;
10771077
executionTime = currentTime - previousTime;
10781078
time = currentTime;

‎src/definitions/globals/site.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
$.site = $.fn.site = function (parameters) {
2323
var
24-
time = new Date().getTime(),
24+
time = Date.now(),
2525
performance = [],
2626

2727
query = arguments[0],
@@ -309,7 +309,7 @@
309309
previousTime
310310
;
311311
if (settings.performance) {
312-
currentTime = new Date().getTime();
312+
currentTime = Date.now();
313313
previousTime = time || currentTime;
314314
executionTime = currentTime - previousTime;
315315
time = currentTime;

‎src/definitions/modules/accordion.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var
2424
$allModules = $(this),
2525

26-
time = new Date().getTime(),
26+
time = Date.now(),
2727
performance = [],
2828

2929
query = arguments[0],
@@ -427,7 +427,7 @@
427427
previousTime
428428
;
429429
if (settings.performance) {
430-
currentTime = new Date().getTime();
430+
currentTime = Date.now();
431431
previousTime = time || currentTime;
432432
executionTime = currentTime - previousTime;
433433
time = currentTime;

‎src/definitions/modules/calendar.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
moduleSelector = $allModules.selector || '',
2828

29-
time = new Date().getTime(),
29+
time = Date.now(),
3030
performance = [],
3131

3232
query = arguments[0],
@@ -1435,7 +1435,7 @@
14351435
previousTime
14361436
;
14371437
if (settings.performance) {
1438-
currentTime = new Date().getTime();
1438+
currentTime = Date.now();
14391439
previousTime = time || currentTime;
14401440
executionTime = currentTime - previousTime;
14411441
time = currentTime;

‎src/definitions/modules/checkbox.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
$allModules = $(this),
2525
moduleSelector = $allModules.selector || '',
2626

27-
time = new Date().getTime(),
27+
time = Date.now(),
2828
performance = [],
2929

3030
query = arguments[0],
@@ -712,7 +712,7 @@
712712
previousTime
713713
;
714714
if (settings.performance) {
715-
currentTime = new Date().getTime();
715+
currentTime = Date.now();
716716
previousTime = time || currentTime;
717717
executionTime = currentTime - previousTime;
718718
time = currentTime;

‎src/definitions/modules/dimmer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var
2424
$allModules = $(this),
2525

26-
time = new Date().getTime(),
26+
time = Date.now(),
2727
performance = [],
2828

2929
query = arguments[0],
@@ -519,7 +519,7 @@
519519
previousTime
520520
;
521521
if (settings.performance) {
522-
currentTime = new Date().getTime();
522+
currentTime = Date.now();
523523
previousTime = time || currentTime;
524524
executionTime = currentTime - previousTime;
525525
time = currentTime;

0 commit comments

Comments
 (0)