Skip to content

Commit dc9662f

Browse files
authored
fix(chore): unify invoke method, removed unused error strings
Some modules missed the error message when a given behavior does not exist, although the error string was already present in the code. On the other hand there were some unused error strings, which i removed.
1 parent 9a0ff54 commit dc9662f

File tree

9 files changed

+17
-8
lines changed

9 files changed

+17
-8
lines changed

src/definitions/behaviors/form.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,6 +1470,8 @@
14701470

14711471
return false;
14721472
} else {
1473+
module.error(error.method, query);
1474+
14731475
return false;
14741476
}
14751477
});

src/definitions/behaviors/state.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,6 @@
626626

627627
// error
628628
error: {
629-
beforeSend: 'The before send function has cancelled state change',
630629
method: 'The method you called is not defined.',
631630
},
632631

src/definitions/modules/modal.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,6 +1256,8 @@
12561256

12571257
return false;
12581258
} else {
1259+
module.error(error.method, query);
1260+
12591261
return false;
12601262
}
12611263
});

src/definitions/modules/popup.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1282,6 +1282,8 @@
12821282

12831283
return false;
12841284
} else {
1285+
module.error(error.method, query);
1286+
12851287
return false;
12861288
}
12871289
});

src/definitions/modules/rating.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
namespace = settings.namespace,
4242
className = settings.className,
43+
error = settings.error,
4344
metadata = settings.metadata,
4445
selector = settings.selector,
4546
cssVars = settings.cssVars,
@@ -431,6 +432,8 @@
431432

432433
return false;
433434
} else {
435+
module.error(error.method, query);
436+
434437
return false;
435438
}
436439
});
@@ -492,7 +495,6 @@
492495

493496
error: {
494497
method: 'The method you called is not defined',
495-
noMaximum: 'No maximum rating specified. Cannot generate HTML automatically',
496498
},
497499

498500
metadata: {

src/definitions/modules/search.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,6 +1234,8 @@
12341234

12351235
return false;
12361236
} else {
1237+
module.error(error.method, query);
1238+
12371239
return false;
12381240
}
12391241
});
@@ -1368,8 +1370,6 @@
13681370
source: 'Cannot search. No source used, and Fomantic API module was not included',
13691371
noResultsHeader: 'No Results',
13701372
noResults: 'Your search returned no results',
1371-
logging: 'Error in debug logging, exiting.',
1372-
noEndpoint: 'No search endpoint was specified',
13731373
noTemplate: 'A valid template name was not specified.',
13741374
oldSearchSyntax: 'searchFullText setting has been renamed fullTextSearch for consistency, please adjust your settings.',
13751375
serverError: 'There was an issue querying the server.',

src/definitions/modules/shape.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,8 @@
709709

710710
return false;
711711
} else {
712+
module.error(error.method, query);
713+
712714
return false;
713715
}
714716
});

src/definitions/modules/sticky.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,6 @@
377377
tagName = $container[0].tagName
378378
;
379379
if (tagName === 'HTML' || tagName === 'body') {
380-
// this can trigger for too many reasons
381-
// module.error(error.container, tagName, $module);
382380
module.determineContainer();
383381
} else {
384382
var tallestHeight = Math.max(module.cache.context.height, module.cache.element.height);
@@ -804,6 +802,8 @@
804802

805803
return false;
806804
} else {
805+
module.error(error.method, query);
806+
807807
return false;
808808
}
809809
});
@@ -896,7 +896,6 @@
896896
onBottom: function () {},
897897

898898
error: {
899-
container: 'Sticky element must be inside a relative container',
900899
visible: 'Element is hidden, you must call refresh after element becomes visible. Use silent setting to suppress this warning in production.',
901900
method: 'The method you called is not defined.',
902901
invalidContext: 'Context specified does not exist',

src/definitions/modules/transition.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -960,6 +960,8 @@
960960

961961
return false;
962962
} else {
963+
module.error(error.method, query);
964+
963965
return false;
964966
}
965967
});
@@ -1075,7 +1077,6 @@
10751077
// possible errors
10761078
error: {
10771079
noAnimation: 'Element is no longer attached to DOM. Unable to animate. Use silent setting to suppress this warning in production.',
1078-
repeated: 'That animation is already occurring, cancelling repeated animation',
10791080
method: 'The method you called is not defined',
10801081
support: 'This browser does not support CSS animations',
10811082
},

0 commit comments

Comments
 (0)