Skip to content

Commit ce85cf3

Browse files
authored
feat(slider): support control over change trigger
This PR adds a new option to the set value or set rangeValue behavior to optionally avoid the onChange callback The change is backward compatible, because when the new parameter is omitted, it behaves like before (triggering the callback) .slider('set value',10,false)
1 parent 4bea8ab commit ce85cf3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/definitions/modules/slider.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -861,11 +861,12 @@ $.fn.slider = function(parameters) {
861861
},
862862

863863
set: {
864-
value: function(newValue) {
864+
value: function(newValue, fireChange) {
865+
fireChange = fireChange !== false;
865866
var toReset = previousValue === undefined;
866867
previousValue = previousValue === undefined ? module.get.value() : previousValue;
867868
module.update.value(newValue, function(value, thumbVal, secondThumbVal) {
868-
if (!initialLoad || settings.fireOnInit){
869+
if ((!initialLoad || settings.fireOnInit) && fireChange){
869870
if (newValue !== previousValue) {
870871
settings.onChange.call(element, value, thumbVal, secondThumbVal);
871872
}
@@ -876,7 +877,8 @@ $.fn.slider = function(parameters) {
876877
}
877878
});
878879
},
879-
rangeValue: function(first, second) {
880+
rangeValue: function(first, second, fireChange) {
881+
fireChange = fireChange !== false;
880882
if(module.is.range()) {
881883
var
882884
min = module.get.min(),
@@ -899,7 +901,7 @@ $.fn.slider = function(parameters) {
899901
value = Math.abs(module.thumbVal - module.secondThumbVal);
900902
module.update.position(module.thumbVal, $thumb);
901903
module.update.position(module.secondThumbVal, $secondThumb);
902-
if (!initialLoad || settings.fireOnInit) {
904+
if ((!initialLoad || settings.fireOnInit) && fireChange) {
903905
if (value !== previousValue) {
904906
settings.onChange.call(element, value, module.thumbVal, module.secondThumbVal);
905907
}

0 commit comments

Comments
 (0)