Skip to content

Commit bdc9edd

Browse files
authored
fix(chore): invalid css values
Some CSS values are invalid which this PR fixes. As a segment has a bottom box shadow by default i kept it for the bottom attached variant while fixing the current invalid assigned value (other elements like message, menu, table dont have a bottom shadow, so the bottom attached variant should also not have some by default
1 parent df306be commit bdc9edd

File tree

8 files changed

+8
-13
lines changed

8 files changed

+8
-13
lines changed

src/definitions/modules/embed.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
display: block;
6969
width: 100%;
7070
height: 100%;
71-
background-color: @placeholderBackground;
71+
background: @placeholderBackground;
7272
}
7373

7474
/* --------------

src/definitions/modules/popup.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@
793793
box-shadow: @invertedBoxShadow;
794794
}
795795
.ui.inverted.popup .header {
796-
background-color: @invertedHeaderBackground;
796+
background: @invertedHeaderBackground;
797797
color: @invertedHeaderColor;
798798
}
799799
.ui.inverted.popup::before {

src/themes/default/collections/menu.variables

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -428,9 +428,7 @@
428428
@attachedWidth: e(%("calc(100%% + %d)", -@attachedHorizontalOffset * 2));
429429
@attachedBoxShadow: none;
430430
@attachedBorder: @borderWidth solid @solidBorderColor;
431-
@attachedBottomBoxShadow:
432-
@boxShadow,
433-
@attachedBoxShadow;
431+
@attachedBottomBoxShadow: @attachedBoxShadow;
434432

435433
/* Resize large sizes */
436434
@mini: @11px;

src/themes/default/collections/table.variables

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,7 @@
166166
@attachedWidth: e(%("calc(100%% + %d)", -@attachedHorizontalOffset * 2));
167167
@attachedBoxShadow: none;
168168
@attachedBorder: @borderWidth solid @solidBorderColor;
169-
@attachedBottomBoxShadow:
170-
@boxShadow,
171-
@attachedBoxShadow;
169+
@attachedBottomBoxShadow: @attachedBoxShadow;
172170

173171
/* Striped */
174172
@stripedBackground: rgba(0, 0, 50, 0.02);

src/themes/default/elements/segment.variables

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@
104104
@attachedWidth: e(%("calc(100%% + %d)", -@attachedHorizontalOffset * 2));
105105
@attachedBoxShadow: none;
106106
@attachedBorder: @borderWidth solid @solidBorderColor;
107-
@attachedBottomBoxShadow:
108-
@boxShadow,
109-
@attachedBoxShadow;
107+
@attachedBottomBoxShadow: @bottomShadow;
110108

111109
/* Inverted */
112110
@invertedBackground: @black;

src/themes/default/elements/step.variables

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
/* Icon */
4343
@iconDistance: 1rem;
4444
@iconSize: 2.5em;
45-
@iconAlign: middle;
45+
@iconAlign: center;
4646

4747
/* Title */
4848
@titleFontFamily: @headerFont;

src/themes/default/globals/site.variables

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,7 @@
649649

650650
/* Differentiating Layers */
651651
@subtleShadow: 0 1px 2px 0 @borderColor;
652+
@bottomShadow: 0 2px 1px -1px @borderColor;
652653
@floatingShadow:
653654
0 2px 4px 0 rgba(34, 36, 38, 0.12),
654655
0 2px 10px 0 rgba(34, 36, 38, 0.15);

src/themes/default/views/item.variables

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101

102102
/* Description */
103103
@descriptionDistance: 0.6em;
104-
@descriptionMaxWidth: auto;
104+
@descriptionMaxWidth: none;
105105
@descriptionFontSize: 1em;
106106
@descriptionLineHeight: @lineHeight;
107107
@descriptionColor: @textColor;

0 commit comments

Comments
 (0)