Skip to content

Commit b4fc00c

Browse files
authored
fix(dropdown): keep overflow visible for non simple selection
This partly reverts #2219 and only adds the overflow setting in case of a simple selection dropdown where a possible scrollbar is only needed. Since 2.9.0 a simple menu item dropdown unfortunately also applied a scrollbar, which is wrong. This PR also fixes upward menu positioning in case a floating simple upward dropdown is used
1 parent 7259c34 commit b4fc00c

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/definitions/modules/dropdown.less

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1479,21 +1479,29 @@ select.ui.dropdown {
14791479

14801480
.ui.simple.active.dropdown > .menu,
14811481
.ui.simple.dropdown:hover > .menu {
1482-
overflow: auto;
1482+
overflow: visible;
14831483
width: auto;
14841484
height: auto;
14851485
top: 100%;
14861486
opacity: 1;
14871487
}
14881488
.ui.simple.dropdown > .menu > .item:active > .menu,
14891489
.ui.simple.dropdown .menu .item:hover > .menu {
1490-
overflow: auto;
1490+
overflow: visible;
14911491
width: auto;
14921492
height: auto;
14931493
top: 0 !important;
14941494
left: 100%;
14951495
opacity: 1;
14961496
}
1497+
& when (@variationDropdownSelection) {
1498+
.ui.simple.selection.active.dropdown > .menu,
1499+
.ui.simple.selection.dropdown:hover > .menu,
1500+
.ui.simple.selection.dropdown > .menu > .item:active > .menu,
1501+
.ui.simple.selection.dropdown .menu .item:hover > .menu {
1502+
overflow: auto;
1503+
}
1504+
}
14971505
.ui.simple.dropdown > .menu > .item:active > .left.menu,
14981506
.ui.simple.dropdown .menu .item:hover > .left.menu,
14991507
.right.menu .ui.simple.dropdown > .menu > .item:active > .menu:not(.right),
@@ -1553,7 +1561,7 @@ select.ui.dropdown {
15531561
.ui:not(.upward).floating.dropdown > .menu {
15541562
margin-top: @floatingMenuDistance;
15551563
}
1556-
.ui.upward.floating.dropdown > .menu {
1564+
.ui.upward.floating.dropdown:not(.simple) > .menu {
15571565
margin-bottom: @floatingMenuDistance;
15581566
}
15591567
}

0 commit comments

Comments
 (0)