fix(chore): encapsulate settimeout

lubber-de · web-flow · commit afea45633568 · 2023-05-05T13:52:55.000+02:00
This PR encapsulates any setTimeout function. We had this almost everywhere except for the performance debugger and some other parts. Especially for the api module this removes potentionally code injection risk warnings from snyk.
diff --git a/src/definitions/behaviors/api.js b/src/definitions/behaviors/api.js
@@ -646,7 +646,7 @@
                                 module.debug('Adding error state');
                                 module.set.error();
                                 if (module.should.removeError()) {
-                                    setTimeout(module.remove.error, settings.errorDuration);
+                                    setTimeout(function () { module.remove.error(); }, settings.errorDuration);
                                 }
                             }
                             module.debug('API Request failed', errorMessage, xhr);
@@ -970,7 +970,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -1494,7 +1494,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/behaviors/state.js b/src/definitions/behaviors/state.js
@@ -482,7 +482,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/behaviors/visibility.js b/src/definitions/behaviors/visibility.js
@@ -1088,7 +1088,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/globals/site.js b/src/definitions/globals/site.js
@@ -292,7 +292,7 @@
                         });
                     }
                     clearTimeout(module.performance.timer);
-                    module.performance.timer = setTimeout(module.performance.display, 500);
+                    module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                 },
                 display: function () {
                     var
diff --git a/src/definitions/modules/accordion.js b/src/definitions/modules/accordion.js
@@ -438,7 +438,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/calendar.js b/src/definitions/modules/calendar.js
@@ -1479,7 +1479,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/checkbox.js b/src/definitions/modules/checkbox.js
@@ -723,7 +723,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
@@ -528,7 +528,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
@@ -1231,7 +1231,7 @@
                             module.set.filtered();
                         }
                         clearTimeout(module.timer);
-                        module.timer = setTimeout(module.search, settings.delay.search);
+                        module.timer = setTimeout(function () { module.search(); }, settings.delay.search);
                     },
                     label: {
                         click: function (event) {
@@ -3742,12 +3742,12 @@
                     show: function () {
                         module.verbose('Delaying show event to ensure user intent');
                         clearTimeout(module.timer);
-                        module.timer = setTimeout(module.show, settings.delay.show);
+                        module.timer = setTimeout(function () { module.show(); }, settings.delay.show);
                     },
                     hide: function () {
                         module.verbose('Delaying hide event to ensure user intent');
                         clearTimeout(module.timer);
-                        module.timer = setTimeout(module.hide, settings.delay.hide);
+                        module.timer = setTimeout(function () { module.hide(); }, settings.delay.hide);
                     },
                 },
 
@@ -3873,7 +3873,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/embed.js b/src/definitions/modules/embed.js
@@ -440,7 +440,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/flyout.js b/src/definitions/modules/flyout.js
@@ -1247,7 +1247,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -527,7 +527,7 @@
                     },
                     debounce: function (method, delay) {
                         clearTimeout(module.timer);
-                        module.timer = setTimeout(method, delay);
+                        module.timer = setTimeout(function () { method(); }, delay);
                     },
                     keyboard: function (event) {
                         var
@@ -1273,7 +1273,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/nag.js b/src/definitions/modules/nag.js
@@ -88,7 +88,7 @@
                     }
 
                     if (settings.displayTime > 0) {
-                        setTimeout(module.hide, settings.displayTime);
+                        setTimeout(function () { module.hide(); }, settings.displayTime);
                     }
                     module.show();
                 },
@@ -377,7 +377,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js
@@ -194,7 +194,7 @@
                         ;
                         clearTimeout(module.hideTimer);
                         if (!openedWithTouch || (openedWithTouch && settings.addTouchEvents)) {
-                            module.showTimer = setTimeout(module.show, delay);
+                            module.showTimer = setTimeout(function () { module.show(); }, delay);
                         }
                     },
                     end: function () {
@@ -204,7 +204,7 @@
                                 : settings.delay
                         ;
                         clearTimeout(module.showTimer);
-                        module.hideTimer = setTimeout(module.hide, delay);
+                        module.hideTimer = setTimeout(function () { module.hide(); }, delay);
                     },
                     touchstart: function (event) {
                         openedWithTouch = true;
@@ -1244,7 +1244,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/progress.js b/src/definitions/modules/progress.js
@@ -791,7 +791,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/rating.js b/src/definitions/modules/rating.js
@@ -368,7 +368,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/search.js b/src/definitions/modules/search.js
@@ -169,7 +169,7 @@
                             callback      = function () {
                                 module.cancel.query();
                                 module.remove.focus();
-                                module.timer = setTimeout(module.hideResults, settings.hideDelay);
+                                module.timer = setTimeout(function () { module.hideResults(); }, settings.hideDelay);
                             }
                         ;
                         if (pageLostFocus) {
@@ -1171,7 +1171,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/shape.js b/src/definitions/modules/shape.js
@@ -623,7 +623,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/sidebar.js b/src/definitions/modules/sidebar.js
@@ -898,7 +898,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/slider.js b/src/definitions/modules/slider.js
@@ -1262,7 +1262,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/sticky.js b/src/definitions/modules/sticky.js
@@ -746,7 +746,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 0);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 0);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js
@@ -786,7 +786,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/toast.js b/src/definitions/modules/toast.js
@@ -702,7 +702,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var
diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js
@@ -142,7 +142,7 @@
                         ? ($allModules.length - index) * interval
                         : index * interval;
                     module.debug('Delaying animation by', delay);
-                    setTimeout(module.animate, delay);
+                    setTimeout(function () { module.animate(); }, delay);
                 },
 
                 animate: function (overrideSettings) {
@@ -849,7 +849,7 @@
                             });
                         }
                         clearTimeout(module.performance.timer);
-                        module.performance.timer = setTimeout(module.performance.display, 500);
+                        module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);
                     },
                     display: function () {
                         var

Original file line number	Diff line number	Diff line change
`@@ -646,7 +646,7 @@`
`646`	`646`	`module.debug('Adding error state');`
`647`	`647`	`module.set.error();`
`648`	`648`	`if (module.should.removeError()) {`
`649`		`- setTimeout(module.remove.error, settings.errorDuration);`
	`649`	`+ setTimeout(function () { module.remove.error(); }, settings.errorDuration);`
`650`	`650`	`}`
`651`	`651`	`}`
`652`	`652`	`module.debug('API Request failed', errorMessage, xhr);`
`@@ -970,7 +970,7 @@`
`970`	`970`	`});`
`971`	`971`	`}`
`972`	`972`	`clearTimeout(module.performance.timer);`
`973`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`973`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`974`	`974`	`},`
`975`	`975`	`display: function () {`
`976`	`976`	`var`
Original file line number	Diff line number	Diff line change
`@@ -1494,7 +1494,7 @@`
`1494`	`1494`	`});`
`1495`	`1495`	`}`
`1496`	`1496`	`clearTimeout(module.performance.timer);`
`1497`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`1497`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`1498`	`1498`	`},`
`1499`	`1499`	`display: function () {`
`1500`	`1500`	`var`
Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@`
`482`	`482`	`});`
`483`	`483`	`}`
`484`	`484`	`clearTimeout(module.performance.timer);`
`485`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`485`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`486`	`486`	`},`
`487`	`487`	`display: function () {`
`488`	`488`	`var`
Original file line number	Diff line number	Diff line change
`@@ -1088,7 +1088,7 @@`
`1088`	`1088`	`});`
`1089`	`1089`	`}`
`1090`	`1090`	`clearTimeout(module.performance.timer);`
`1091`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`1091`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`1092`	`1092`	`},`
`1093`	`1093`	`display: function () {`
`1094`	`1094`	`var`
Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@`
`292`	`292`	`});`
`293`	`293`	`}`
`294`	`294`	`clearTimeout(module.performance.timer);`
`295`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`295`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`296`	`296`	`},`
`297`	`297`	`display: function () {`
`298`	`298`	`var`
Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,7 @@`
`438`	`438`	`});`
`439`	`439`	`}`
`440`	`440`	`clearTimeout(module.performance.timer);`
`441`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`441`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`442`	`442`	`},`
`443`	`443`	`display: function () {`
`444`	`444`	`var`
Original file line number	Diff line number	Diff line change
`@@ -1479,7 +1479,7 @@`
`1479`	`1479`	`});`
`1480`	`1480`	`}`
`1481`	`1481`	`clearTimeout(module.performance.timer);`
`1482`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`1482`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`1483`	`1483`	`},`
`1484`	`1484`	`display: function () {`
`1485`	`1485`	`var`
Original file line number	Diff line number	Diff line change
`@@ -723,7 +723,7 @@`
`723`	`723`	`});`
`724`	`724`	`}`
`725`	`725`	`clearTimeout(module.performance.timer);`
`726`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`726`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`727`	`727`	`},`
`728`	`728`	`display: function () {`
`729`	`729`	`var`
Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,7 @@`
`528`	`528`	`});`
`529`	`529`	`}`
`530`	`530`	`clearTimeout(module.performance.timer);`
`531`		`- module.performance.timer = setTimeout(module.performance.display, 500);`
	`531`	`+ module.performance.timer = setTimeout(function () { module.performance.display(); }, 500);`
`532`	`532`	`},`
`533`	`533`	`display: function () {`
`534`	`534`	`var`