Skip to content

Commit 93605f5

Browse files
authored
fix(input): better differ between left/right icon/action
When ui right action left icon input is used, the current CSS selector is unclear and gets confused when also a left icon is used: The left corners are not rounded.
1 parent 8a49912 commit 93605f5

File tree

2 files changed

+36
-32
lines changed

2 files changed

+36
-32
lines changed

src/definitions/collections/form.less

Lines changed: 32 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -414,36 +414,40 @@
414414
box-shadow: @inputFocusBoxShadow;
415415
}
416416
& when (@variationInputAction) {
417-
.ui.form .ui.action.input:not(.left) input:not([type]):focus,
418-
.ui.form .ui.action.input:not(.left) input[type="date"]:focus,
419-
.ui.form .ui.action.input:not(.left) input[type="datetime-local"]:focus,
420-
.ui.form .ui.action.input:not(.left) input[type="email"]:focus,
421-
.ui.form .ui.action.input:not(.left) input[type="number"]:focus,
422-
.ui.form .ui.action.input:not(.left) input[type="password"]:focus,
423-
.ui.form .ui.action.input:not(.left) input[type="search"]:focus,
424-
.ui.form .ui.action.input:not(.left) input[type="tel"]:focus,
425-
.ui.form .ui.action.input:not(.left) input[type="time"]:focus,
426-
.ui.form .ui.action.input:not(.left) input[type="text"]:focus,
427-
.ui.form .ui.action.input:not(.left) input[type="file"]:focus,
428-
.ui.form .ui.action.input:not(.left) input[type="url"]:focus {
429-
border-top-right-radius: 0;
430-
border-bottom-right-radius: 0;
417+
.ui.form .ui.action.input:not([class*="left action"]) {
418+
& input:not([type]):focus,
419+
input[type="date"]:focus,
420+
input[type="datetime-local"]:focus,
421+
input[type="email"]:focus,
422+
input[type="number"]:focus,
423+
input[type="password"]:focus,
424+
input[type="search"]:focus,
425+
input[type="tel"]:focus,
426+
input[type="time"]:focus,
427+
input[type="text"]:focus,
428+
input[type="file"]:focus,
429+
input[type="url"]:focus {
430+
border-top-right-radius: 0;
431+
border-bottom-right-radius: 0;
432+
}
431433
}
432434

433-
.ui.form .ui.action.input.left input:not([type]),
434-
.ui.form .ui.action.input.left input[type="date"],
435-
.ui.form .ui.action.input.left input[type="datetime-local"],
436-
.ui.form .ui.action.input.left input[type="email"],
437-
.ui.form .ui.action.input.left input[type="number"],
438-
.ui.form .ui.action.input.left input[type="password"],
439-
.ui.form .ui.action.input.left input[type="search"],
440-
.ui.form .ui.action.input.left input[type="tel"],
441-
.ui.form .ui.action.input.left input[type="time"],
442-
.ui.form .ui.action.input.left input[type="text"],
443-
.ui.form .ui.action.input.left input[type="file"],
444-
.ui.form .ui.action.input.left input[type="url"] {
445-
border-bottom-left-radius: 0;
446-
border-top-left-radius: 0;
435+
.ui.form .ui[class*="left action"].input {
436+
& input:not([type]),
437+
input[type="date"],
438+
input[type="datetime-local"],
439+
input[type="email"],
440+
input[type="number"],
441+
input[type="password"],
442+
input[type="search"],
443+
input[type="tel"],
444+
input[type="time"],
445+
input[type="text"],
446+
input[type="file"],
447+
input[type="url"] {
448+
border-bottom-left-radius: 0;
449+
border-top-left-radius: 0;
450+
}
447451
}
448452
}
449453
.ui.form textarea:focus {

src/definitions/elements/input.less

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,15 +444,15 @@
444444
border-top: @borderWidth solid @borderColor;
445445
border-bottom: @borderWidth solid @borderColor;
446446
}
447-
.ui.form > .field.@{state} > .ui.left.action.input > .ui.button,
447+
.ui.form > .field.@{state} > .ui[class*="left action"].input > .ui.button,
448448
.ui.form > .field.@{state} > .ui.labeled.input:not(.right):not([class*="corner labeled"]) > .ui.label,
449-
.ui.left.action.input.@{state} > .ui.button,
449+
.ui[class*="left action"].input.@{state} > .ui.button,
450450
.ui.labeled.input.@{state}:not(.right):not([class*="corner labeled"]) > .ui.label {
451451
border-left: @borderWidth solid @borderColor;
452452
}
453-
.ui.form > .field.@{state} > .ui.action.input:not(.left) > input + .ui.button,
453+
.ui.form > .field.@{state} > .ui.action.input:not([class*="left action"]) > input + .ui.button,
454454
.ui.form > .field.@{state} > .ui.right.labeled.input:not([class*="corner labeled"]) > input + .ui.label,
455-
.ui.action.input.@{state}:not(.left) > input + .ui.button,
455+
.ui.action.input.@{state}:not([class*="left action"]) > input + .ui.button,
456456
.ui.right.labeled.input.@{state}:not([class*="corner labeled"]) > input + .ui.label {
457457
border-right: @borderWidth solid @borderColor;
458458
}

0 commit comments

Comments
 (0)