Skip to content

Commit 9025236

Browse files
authored
feat(calendar): move hardcoded values to less variables
Moves some hardcoded values into LESS variables as discussed in #2866
1 parent 1afaf65 commit 9025236

File tree

2 files changed

+26
-15
lines changed

2 files changed

+26
-15
lines changed

src/definitions/modules/calendar.less

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -60,24 +60,24 @@
6060
.ui.calendar .ui.table.year,
6161
.ui.calendar .ui.table.month,
6262
.ui.calendar .ui.table.minute {
63-
min-width: 15em;
63+
min-width: @widthYearMonthMinute;
6464
}
6565

6666
.ui.calendar .ui.table.day {
67-
min-width: 18em;
67+
min-width: @widthDay;
6868
}
6969

7070
.ui.calendar .ui.table.day.andweek {
71-
min-width: 22em;
71+
min-width: @widthDayAndWeek;
7272
}
7373

7474
.ui.calendar .ui.table.hour {
75-
min-width: 20em;
75+
min-width: @widthHour;
7676
}
7777

7878
.ui.calendar .ui.table tr th,
7979
.ui.calendar .ui.table tr td {
80-
padding: 0.5em;
80+
padding: @cellPadding;
8181
white-space: nowrap;
8282
}
8383

@@ -100,27 +100,27 @@
100100
}
101101

102102
.ui.calendar .ui.table.day tr:nth-child(2) th {
103-
padding-top: 0.2em;
104-
padding-bottom: 0.3em;
103+
padding-top: @cellHeaderTopPadding;
104+
padding-bottom: @cellHeaderBottomPadding;
105105
}
106106

107107
.ui.calendar .ui.table tr td {
108-
padding-left: 0.1em;
109-
padding-right: 0.1em;
108+
padding-left: @cellLeftRightPadding;
109+
padding-right: @cellLeftRightPadding;
110110
}
111111

112112
.ui.calendar .ui.table tr .link {
113113
cursor: pointer;
114114
}
115115

116116
.ui.calendar .ui.table tr .prev.link {
117-
width: 14.28571%;
117+
width: @widthPrevNext;
118118
position: absolute;
119119
left: 0;
120120
}
121121

122122
.ui.calendar .ui.table tr .next.link {
123-
width: 14.28571%;
123+
width: @widthPrevNext;
124124
position: absolute;
125125
right: 0;
126126
}
@@ -211,16 +211,16 @@
211211
.ui.@{value}.calendar .ui.table.year,
212212
.ui.@{value}.calendar .ui.table.month,
213213
.ui.@{value}.calendar .ui.table.minute {
214-
min-width: unit(15 * @s, em);
214+
min-width: unit(@widthYearMonthMinute * @s, em);
215215
}
216216
.ui.@{value}.calendar .ui.table.day {
217-
min-width: unit(18 * @s, em);
217+
min-width: unit(@widthDay * @s, em);
218218
}
219219
.ui.@{value}.calendar .ui.table.day.andweek {
220-
min-width: unit(22 * @s, em);
220+
min-width: unit(@widthDayAndWeek * @s, em);
221221
}
222222
.ui.@{value}.calendar .ui.table.hour {
223-
min-width: unit(20 * @s, em);
223+
min-width: unit(@widthHour * @s, em);
224224
}
225225
});
226226
}

src/themes/default/modules/calendar.variables

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,14 @@
2323

2424
@multiMonthMargin: -1rem;
2525
@multiMonthPadding: 0;
26+
27+
@cellPadding: 0.5em;
28+
@cellLeftRightPadding: 0.1em;
29+
@cellHeaderTopPadding: 0.2em;
30+
@cellHeaderBottomPadding: 0.3em;
31+
32+
@widthPrevNext: (100% / 7);
33+
@widthYearMonthMinute: 15em;
34+
@widthDay: 18em;
35+
@widthDayAndWeek: 22em;
36+
@widthHour: 20em;

0 commit comments

Comments
 (0)