Skip to content

Commit 891f6e6

Browse files
authored
fix(dropdown): very short menu had wrong order specificity
The very short size variation did not work. It was always overridden by the short variation because both share same specificity, thus the declaration order matters.
1 parent e1a8393 commit 891f6e6

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/definitions/modules/dropdown.less

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -448,12 +448,12 @@ select.ui.dropdown {
448448

449449
@media only screen and (max-width : @largestMobileScreen) {
450450
& when (@variationDropdownShort) {
451-
.ui.selection.dropdown[class*="very short"] .menu {
452-
max-height: @selectionMobileMaxMenuHeight * 0.5;
453-
}
454451
.ui.selection.dropdown.short .menu {
455452
max-height: @selectionMobileMaxMenuHeight * 0.75;
456453
}
454+
.ui.selection.dropdown[class*="very short"] .menu {
455+
max-height: @selectionMobileMaxMenuHeight * 0.5;
456+
}
457457
}
458458
.ui.selection.dropdown .menu {
459459
max-height: @selectionMobileMaxMenuHeight;
@@ -469,12 +469,12 @@ select.ui.dropdown {
469469
}
470470
@media only screen and (min-width: @tabletBreakpoint) {
471471
& when (@variationDropdownShort) {
472-
.ui.selection.dropdown[class*="very short"] .menu {
473-
max-height: @selectionTabletMaxMenuHeight * 0.5;
474-
}
475472
.ui.selection.dropdown.short .menu {
476473
max-height: @selectionTabletMaxMenuHeight * 0.75;
477474
}
475+
.ui.selection.dropdown[class*="very short"] .menu {
476+
max-height: @selectionTabletMaxMenuHeight * 0.5;
477+
}
478478
}
479479
.ui.selection.dropdown .menu {
480480
max-height: @selectionTabletMaxMenuHeight;
@@ -490,12 +490,12 @@ select.ui.dropdown {
490490
}
491491
@media only screen and (min-width: @computerBreakpoint) {
492492
& when (@variationDropdownShort) {
493-
.ui.selection.dropdown[class*="very short"] .menu {
494-
max-height: @selectionComputerMaxMenuHeight * 0.5;
495-
}
496493
.ui.selection.dropdown.short .menu {
497494
max-height: @selectionComputerMaxMenuHeight * 0.75;
498495
}
496+
.ui.selection.dropdown[class*="very short"] .menu {
497+
max-height: @selectionComputerMaxMenuHeight * 0.5;
498+
}
499499
}
500500
.ui.selection.dropdown .menu {
501501
max-height: @selectionComputerMaxMenuHeight;
@@ -511,12 +511,12 @@ select.ui.dropdown {
511511
}
512512
@media only screen and (min-width: @widescreenMonitorBreakpoint) {
513513
& when (@variationDropdownShort) {
514-
.ui.selection.dropdown[class*="very short"] .menu {
515-
max-height: @selectionWidescreenMaxMenuHeight * 0.5;
516-
}
517514
.ui.selection.dropdown.short .menu {
518515
max-height: @selectionWidescreenMaxMenuHeight * 0.75;
519516
}
517+
.ui.selection.dropdown[class*="very short"] .menu {
518+
max-height: @selectionWidescreenMaxMenuHeight * 0.5;
519+
}
520520
}
521521
.ui.selection.dropdown .menu {
522522
max-height: @selectionWidescreenMaxMenuHeight;

0 commit comments

Comments
 (0)