Skip to content

Commit 8838309

Browse files
lubber-delubber-de
authored
feat(chore): remove vendor checks
Thir PR removes some vendor checks as we are not supporting very old browsers anymore where such checks were necessary
1 parent 5b497e3 commit 8838309

File tree

14 files changed

+54
-192
lines changed

14 files changed

+54
-192
lines changed

‎src/definitions/behaviors/form.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,7 @@
888888
.html(settings.templates.prompt(errors))
889889
;
890890
if (!promptExists) {
891-
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
891+
if (settings.transition && module.can.useElement('transition')) {
892892
module.verbose('Displaying error with css transition', settings.transition);
893893
$prompt.transition(settings.transition + ' in', settings.duration);
894894
} else {
@@ -984,7 +984,7 @@
984984
;
985985
if (settings.inline && $prompt.is(':visible')) {
986986
module.verbose('Removing prompt for field', identifier);
987-
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
987+
if (settings.transition && module.can.useElement('transition')) {
988988
$prompt.transition(settings.transition + ' out', settings.duration, function () {
989989
$prompt.remove();
990990
});

‎src/definitions/modules/accordion.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
.addClass(className.animating)
176176
;
177177
if (settings.animateChildren) {
178-
if ($.fn.transition !== undefined && $module.transition('is supported')) {
178+
if ($.fn.transition !== undefined) {
179179
$activeContent
180180
.children()
181181
.transition({
@@ -239,7 +239,7 @@
239239
.addClass(className.animating)
240240
;
241241
if (settings.animateChildren) {
242-
if ($.fn.transition !== undefined && $module.transition('is supported')) {
242+
if ($.fn.transition !== undefined) {
243243
$activeContent
244244
.children()
245245
.transition({
@@ -308,7 +308,7 @@
308308
.stop(true, true)
309309
;
310310
if (settings.animateChildren) {
311-
if ($.fn.transition !== undefined && $module.transition('is supported')) {
311+
if ($.fn.transition !== undefined) {
312312
$openContents
313313
.children()
314314
.transition({

‎src/definitions/modules/dimmer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
callback = isFunction(callback)
230230
? callback
231231
: function () {};
232-
if (settings.useCSS && $.fn.transition !== undefined && $dimmer.transition('is supported')) {
232+
if (settings.useCSS && $.fn.transition !== undefined) {
233233
if (settings.useFlex) {
234234
module.debug('Using flex dimmer');
235235
module.remove.legacy();
@@ -288,7 +288,7 @@
288288
callback = isFunction(callback)
289289
? callback
290290
: function () {};
291-
if (settings.useCSS && $.fn.transition !== undefined && $dimmer.transition('is supported')) {
291+
if (settings.useCSS && $.fn.transition !== undefined) {
292292
module.verbose('Hiding dimmer with css');
293293
$dimmer
294294
.transition({

‎src/definitions/modules/dropdown.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3637,7 +3637,7 @@
36373637
displayType: module.get.displayType(),
36383638
}).transition('show');
36393639
callback.call(element);
3640-
} else if (module.can.useElement('transition') && $module.transition('is supported')) {
3640+
} else if (module.can.useElement('transition')) {
36413641
$currentMenu
36423642
.transition({
36433643
animation: transition + ' in',
@@ -3679,7 +3679,7 @@
36793679
displayType: module.get.displayType(),
36803680
}).transition('hide');
36813681
callback.call(element);
3682-
} else if ($.fn.transition !== undefined && $module.transition('is supported')) {
3682+
} else if ($.fn.transition !== undefined) {
36833683
$currentMenu
36843684
.transition({
36853685
animation: transition + ' out',

‎src/definitions/modules/embed.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@
655655
return ''
656656
+ '<iframe src="' + deQuote(src) + '"'
657657
+ ' width="100%" height="100%"'
658-
+ ' webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>';
658+
+ ' msallowFullScreen allowFullScreen></iframe>';
659659
},
660660
placeholder: function (image, icon) {
661661
var

‎src/definitions/modules/flyout.js

Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
observer,
8383
observeAttributes = false,
8484
currentScroll,
85-
transitionEvent,
8685

8786
module
8887
;
@@ -146,8 +145,6 @@
146145
});
147146
}
148147

149-
transitionEvent = module.get.transitionEvent();
150-
151148
// avoids locking rendering if initialized in onReady
152149
if (settings.delaySetup) {
153150
requestAnimationFrame(module.setup.layout);
@@ -757,13 +754,13 @@
757754
};
758755
transitionEnd = function (event) {
759756
if (event.target === $module[0]) {
760-
$module.off(transitionEvent + elementNamespace, transitionEnd);
757+
$module.off('transitionend' + elementNamespace, transitionEnd);
761758
module.remove.animating();
762759
callback.call(element);
763760
}
764761
};
765-
$module.off(transitionEvent + elementNamespace);
766-
$module.on(transitionEvent + elementNamespace, transitionEnd);
762+
$module.off('transitionend' + elementNamespace);
763+
$module.on('transitionend' + elementNamespace, transitionEnd);
767764
requestAnimationFrame(animate);
768765
if (settings.dimPage && !module.othersVisible()) {
769766
requestAnimationFrame(dim);
@@ -798,7 +795,7 @@
798795
};
799796
transitionEnd = function (event) {
800797
if (event.target === $module[0]) {
801-
$module.off(transitionEvent + elementNamespace, transitionEnd);
798+
$module.off('transitionend' + elementNamespace, transitionEnd);
802799
module.remove.animating();
803800
module.remove.closing();
804801
module.remove.overlay();
@@ -812,8 +809,8 @@
812809
callback.call(element);
813810
}
814811
};
815-
$module.off(transitionEvent + elementNamespace);
816-
$module.on(transitionEvent + elementNamespace, transitionEnd);
812+
$module.off('transitionend' + elementNamespace);
813+
$module.on('transitionend' + elementNamespace, transitionEnd);
817814
requestAnimationFrame(animate);
818815
},
819816

@@ -981,23 +978,6 @@
981978

982979
return className.left;
983980
},
984-
transitionEvent: function () {
985-
var
986-
element = document.createElement('element'),
987-
transitions = {
988-
transition: 'transitionend',
989-
OTransition: 'oTransitionEnd',
990-
MozTransition: 'transitionend',
991-
WebkitTransition: 'webkitTransitionEnd',
992-
},
993-
transition
994-
;
995-
for (transition in transitions) {
996-
if (element.style[transition] !== undefined) {
997-
return transitions[transition];
998-
}
999-
}
1000-
},
1001981
id: function () {
1002982
return id;
1003983
},

‎src/definitions/modules/modal.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@
606606
$module.detach().appendTo($dimmer);
607607
}
608608
}
609-
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
609+
if (settings.transition && $.fn.transition !== undefined) {
610610
module.debug('Showing modal with css animations');
611611
module.set.observeAttributes(false);
612612
$module
@@ -656,7 +656,7 @@
656656

657657
if (module.is.animating() || module.is.active()) {
658658
module.debug('Hiding modal');
659-
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
659+
if (settings.transition && $.fn.transition !== undefined) {
660660
module.remove.active();
661661
module.set.observeAttributes(false);
662662
$module
@@ -994,9 +994,7 @@
994994
return module.cache.isIE;
995995
},
996996
animating: function () {
997-
return $module.transition('is supported')
998-
? $module.transition('is animating')
999-
: $module.is(':visible');
997+
return $module.transition('is animating');
1000998
},
1001999
scrolling: function () {
10021000
return $dimmable.hasClass(className.scrolling);

‎src/definitions/modules/popup.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@
414414
animate: {
415415
show: function (callback) {
416416
callback = isFunction(callback) ? callback : function () {};
417-
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
417+
if (settings.transition && module.can.useElement('transition')) {
418418
module.set.visible();
419419
$popup
420420
.transition({
@@ -436,7 +436,7 @@
436436
hide: function (callback) {
437437
callback = isFunction(callback) ? callback : function () {};
438438
module.debug('Hiding pop-up');
439-
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
439+
if (settings.transition && $.fn.transition !== undefined) {
440440
$popup
441441
.transition({
442442
animation: (settings.transition.hideMethod || settings.transition) + ' out',

‎src/definitions/modules/progress.js

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
instance = $module.data(moduleNamespace),
6060

6161
animating = false,
62-
transitionEnd,
6362
module
6463
;
6564
module = {
@@ -115,7 +114,6 @@
115114

116115
initialize: function () {
117116
module.set.duration();
118-
module.set.transitionEvent();
119117
module.debug(element);
120118

121119
module.read.metadata();
@@ -195,17 +193,14 @@
195193

196194
bind: {
197195
transitionEnd: function (callback) {
198-
var
199-
transitionEnd = module.get.transitionEnd()
200-
;
201196
$bars
202-
.one(transitionEnd + eventNamespace, function (event) {
197+
.one('transitionend' + eventNamespace, function (event) {
203198
clearTimeout(module.failSafeTimer);
204199
callback.call(this, event);
205200
})
206201
;
207202
module.failSafeTimer = setTimeout(function () {
208-
$bars.triggerHandler(transitionEnd);
203+
$bars.triggerHandler('transitionend');
209204
}, settings.duration + settings.failSafeDelay);
210205
module.verbose('Adding fail safe timer', module.timer);
211206
},
@@ -330,24 +325,6 @@
330325
: value;
331326
},
332327

333-
transitionEnd: function () {
334-
var
335-
element = document.createElement('element'),
336-
transitions = {
337-
transition: 'transitionend',
338-
OTransition: 'oTransitionEnd',
339-
MozTransition: 'transitionend',
340-
WebkitTransition: 'webkitTransitionEnd',
341-
},
342-
transition
343-
;
344-
for (transition in transitions) {
345-
if (element.style[transition] !== undefined) {
346-
return transitions[transition];
347-
}
348-
}
349-
},
350-
351328
// gets current displayed percentage (if animating values this is the intermediary value)
352329
displayPercent: function (index) {
353330
var
@@ -687,9 +664,6 @@
687664
settings.onError.call(element, module.value, module.total);
688665
});
689666
},
690-
transitionEvent: function () {
691-
transitionEnd = module.get.transitionEnd();
692-
},
693667
total: function (totalValue) {
694668
module.total = totalValue;
695669
},

‎src/definitions/modules/search.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@
408408
return module.is.focused() && !module.is.visible() && !module.is.empty();
409409
},
410410
transition: function () {
411-
return settings.transition && $.fn.transition !== undefined && $module.transition('is supported');
411+
return settings.transition && $.fn.transition !== undefined;
412412
},
413413
},
414414

0 commit comments

Comments
 (0)