strictly autofix all rare errors

mvorisek · mvorisek · commit 60f5f674c66a · 2022-12-12T08:27:32.000+01:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -160,21 +160,6 @@ module.exports = {
         'unicorn/prefer-regexp-test': 'off',
         'unicorn/prefer-switch': 'off',
         'unicorn/prefer-ternary': 'off',
-
-        // TODO rare errors
-        'arrow-body-style': 'off',
-        'block-scoped-var': 'off',
-        'import/no-extraneous-dependencies': 'off',
-        'import/order': 'off',
-        'new-cap': 'off',
-        'newline-per-chained-call': 'off',
-        'no-extra-boolean-cast': 'off',
-        'no-redeclare': 'off',
-        'no-unneeded-ternary': 'off',
-        'no-useless-return': 'off',
-        'operator-assignment': 'off',
-        'unicorn/no-console-spaces': 'off',
-        yoda: 'off',
     },
     reportUnusedDisableDirectives: true,
     globals: {
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -1682,7 +1682,7 @@
 
             // is not empty or blank string
             empty: function (value) {
-                return !(value === undefined || '' === value || Array.isArray(value) && value.length === 0);
+                return !(value === undefined || value === '' || Array.isArray(value) && value.length === 0);
             },
 
             // checkbox checked
diff --git a/src/definitions/modules/calendar.js b/src/definitions/modules/calendar.js
@@ -334,7 +334,8 @@
                             if (isDay && settings.showWeekNumbers) {
                                 tempMode += ' andweek';
                             }
-                            var table = $('<table/>').addClass(className.table).addClass(tempMode).addClass(numberText[columns] + ' column').appendTo(container);
+                            var table = $('<table/>').addClass(className.table).addClass(tempMode).addClass(numberText[columns] + ' column')
+                                .appendTo(container);
                             if (isInverted) {
                                 table.addClass(className.inverted);
                             }
@@ -1646,7 +1647,8 @@
                 if (!text) {
                     return null;
                 }
-                text = String(text).trim().replace(/([.:\/\-])\s+/g, '$1').replace(/\s+([.:\/-])/g, '$1').replace(/\s+/g, ' ');
+                text = String(text).trim().replace(/([.:\/\-])\s+/g, '$1').replace(/\s+([.:\/-])/g, '$1')
+                    .replace(/\s+/g, ' ');
                 if (text.length === 0) {
                     return null;
                 }
@@ -1766,7 +1768,7 @@
                             if (isNaN(j)) {
                                 continue;
                             }
-                            if (1 <= j && j <= 12) {
+                            if (j >= 1 && j <= 12) {
                                 month = j;
                                 numbers.splice(k, 1);
 
@@ -1781,7 +1783,7 @@
                         if (isNaN(j)) {
                             continue;
                         }
-                        if (1 <= j && j <= 31) {
+                        if (j >= 1 && j <= 31) {
                             day = j;
                             numbers.splice(i, 1);
 
@@ -1815,7 +1817,7 @@
                             if (isNaN(j)) {
                                 continue;
                             }
-                            if (0 <= j && j <= 23) {
+                            if (j >= 0 && j <= 23) {
                                 hour = j;
                                 numbers.splice(i, 1);
 
@@ -1831,7 +1833,7 @@
                             if (isNaN(j)) {
                                 continue;
                             }
-                            if (0 <= j && j <= 59) {
+                            if (j >= 0 && j <= 59) {
                                 minute = j;
                                 numbers.splice(i, 1);
 
diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
@@ -721,7 +721,7 @@
                         .addClass(settings.className.loader)
                         .addClass(settings.loaderVariation)
                     ;
-                    if (!!settings.loaderText) {
+                    if (settings.loaderText) {
                         l.text(settings.loaderText);
                         l.addClass('text');
                     }
diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
@@ -3304,9 +3304,7 @@
                                 : (values == value)
                         ;
 
-                        return (hasValue)
-                            ? true
-                            : false;
+                        return !!(hasValue);
                     },
                     valueIgnoringCase: function (value) {
                         var
diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js
@@ -371,9 +371,7 @@
                     if (settings.inline || settings.popup) {
                         return (module.has.popup());
                     } else {
-                        return ($popup.closest($context).length >= 1)
-                            ? true
-                            : false;
+                        return ($popup.closest($context).length >= 1);
                     }
                 },
 
diff --git a/src/definitions/modules/progress.js b/src/definitions/modules/progress.js
@@ -95,7 +95,7 @@
                         var precision = 1;
                         var ratio = min / total;
                         while (precisionPower < 10) {
-                            ratio = ratio * precision;
+                            ratio *= precision;
                             if (ratio > 1) {
                                 break;
                             }
diff --git a/src/definitions/modules/toast.js b/src/definitions/modules/toast.js
@@ -309,7 +309,7 @@
                         }
                         if (settings.displayTime > 0) {
                             var progressingClass = className.progressing + ' ' + (settings.pauseOnHover ? className.pausable : '');
-                            if (!!settings.showProgress) {
+                            if (settings.showProgress) {
                                 $progress = $('<div/>', {
                                     class: className.progress + ' ' + (settings.classProgress || settings.class),
                                     'data-percent': '',
diff --git a/tasks/config/project/config.js b/tasks/config/project/config.js
@@ -26,8 +26,6 @@ module.exports = {
                 if (fs.existsSync(currentPath)) {
                     // found file
                     configPath = path.normalize(directory);
-
-                    return;
                 } else {
                     // reached file system root, let's stop
                     if (nextDirectory == directory) {
diff --git a/tasks/config/tasks.js b/tasks/config/tasks.js
@@ -18,9 +18,7 @@ let overrideBrowserslist = hasBrowserslistConfig ? undefined : [
 ];
 
 // Node 12 does not support ??, so a little polyfill
-let nullish = (value, fallback) => {
-    return value !== undefined && value !== null ? value : fallback;
-};
+let nullish = (value, fallback) => (value !== undefined && value !== null ? value : fallback);
 
 module.exports = {
 
@@ -120,7 +118,7 @@ module.exports = {
                         if (error.line == 9) {
                             element = regExp.variable.exec(error.message)[1];
                             if (element) {
-                                console.error('Missing theme.config value for ', element);
+                                console.error('Missing theme.config value for', element);
                             }
                             console.error('Most likely new UI was added in an update. You will need to add missing elements from theme.config.example');
                         } else if (error.line == 84) {
diff --git a/tasks/install.js b/tasks/install.js
@@ -153,7 +153,7 @@ module.exports = function (callback) {
                 return;
             }
         } else {
-            console.error('Cannot locate files to update at path: ', updatePaths.definition);
+            console.error('Cannot locate files to update at path:', updatePaths.definition);
             console.log('Running installer');
         }
     }
@@ -342,7 +342,7 @@ module.exports = function (callback) {
             ;
 
             // rewrite site variable in theme.less
-            console.info('Adjusting @siteFolder to: ', pathToSite + '/');
+            console.info('Adjusting @siteFolder to:', pathToSite + '/');
 
             if (fs.existsSync(installPaths.themeConfig)) {
                 console.info('Modifying src/theme.config (LESS config)', installPaths.themeConfig);
diff --git a/test/.eslintrc.js b/test/.eslintrc.js
@@ -9,10 +9,6 @@ module.exports = {
     },
     rules: {
         'jest/no-disabled-tests': 'off',
-
-        // TODO rare errors
-        'jest/no-jasmine-globals': 'off',
-        'jest/no-test-prefixes': 'off',
     },
     globals: {
         jQuery: false,
diff --git a/test/modules/popup.spec.js b/test/modules/popup.spec.js
@@ -1,4 +1,4 @@
-xdescribe('UI Popup', function () {
+describe.skip('UI Popup', function () {
     moduleTests({
         module: 'popup',
         element: 'i.icon',
diff --git a/test/modules/search.spec.js b/test/modules/search.spec.js
@@ -1,4 +1,4 @@
-xdescribe('UI Search', function () {
+describe.skip('UI Search', function () {
     moduleTests({
         module: 'search',
         element: '.ui.search',
diff --git a/test/modules/tab.spec.js b/test/modules/tab.spec.js
@@ -1,4 +1,4 @@
-xdescribe('UI Tab', function () {
+describe.skip('UI Tab', function () {
     moduleTests({
         module: 'tab',
         element: '.ui.menu .item',
diff --git a/test/modules/transition.spec.js b/test/modules/transition.spec.js
@@ -1,4 +1,4 @@
-xdescribe('UI Transition', function () {
+describe.skip('UI Transition', function () {
     moduleTests({
         module: 'transition',
         element: '.ui.image',

Original file line number	Diff line number	Diff line change
`@@ -721,7 +721,7 @@`
`721`	`721`	`.addClass(settings.className.loader)`
`722`	`722`	`.addClass(settings.loaderVariation)`
`723`	`723`	`;`
`724`		`- if (!!settings.loaderText) {`
	`724`	`+ if (settings.loaderText) {`
`725`	`725`	`l.text(settings.loaderText);`
`726`	`726`	`l.addClass('text');`
`727`	`727`	`}`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@`
`95`	`95`	`var precision = 1;`
`96`	`96`	`var ratio = min / total;`
`97`	`97`	`while (precisionPower < 10) {`
`98`		`- ratio = ratio * precision;`
	`98`	`+ ratio *= precision;`
`99`	`99`	`if (ratio > 1) {`
`100`	`100`	`break;`
`101`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@`
`309`	`309`	`}`
`310`	`310`	`if (settings.displayTime > 0) {`
`311`	`311`	`var progressingClass = className.progressing + ' ' + (settings.pauseOnHover ? className.pausable : '');`
`312`		`- if (!!settings.showProgress) {`
	`312`	`+ if (settings.showProgress) {`
`313`	`313`	`$progress = $('<div/>', {`
`314`	`314`	`class: className.progress + ' ' + (settings.classProgress \|\| settings.class),`
`315`	`315`	`'data-percent': '',`