Skip to content

Commit 34acb50

Browse files
authored
fix(dropdown): create label before changing value as in 2.8.8
This PR reverts the order change of add.value and add.label introduced in #1854 There was no reason doing so. But this change now had an impact when trying to access the labels inside the onchange callback as the (new) labels are now not available yet when onChange is called (as it was unil 2.8.8)
1 parent 9e5d2f7 commit 34acb50

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/definitions/modules/dropdown.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2806,8 +2806,8 @@
28062806
module.save.remoteData(selectedText, selectedValue);
28072807
}
28082808
if (settings.useLabels) {
2809-
module.add.value(selectedValue, selectedText, $selected, preventChangeTrigger);
28102809
module.add.label(selectedValue, selectedText, shouldAnimate);
2810+
module.add.value(selectedValue, selectedText, $selected, preventChangeTrigger);
28112811
module.set.activeItem($selected);
28122812
module.filterActive();
28132813
module.select.nextAvailable($selectedItem);

0 commit comments

Comments
 (0)