Skip to content

Commit 117dc67

Browse files
committed
fix "configConst" and mutating imported config
1 parent 7bd2e54 commit 117dc67

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

tasks/config/project/config.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*******************************/
44

55
let
6-
extend = require('extend'),
76
fs = require('fs'),
87
path = require('path'),
98

@@ -50,8 +49,6 @@ module.exports = {
5049

5150
// adds additional derived values to a config object
5251
addDerivedValues: function (config) {
53-
config = config || extend(false, {}, defaults);
54-
5552
/* --------------
5653
File Paths
5754
--------------- */
@@ -140,8 +137,6 @@ module.exports = {
140137
config.globs.individuals = individuals.length === 1 ? individuals[0] : (individuals.length > 1)
141138
? '{' + individuals.join(',') + '}'
142139
: undefined;
143-
144-
return config;
145140
},
146141

147142
};

tasks/docs/build.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
*******************************/
44

55
let
6+
extend = require('extend'),
67
gulp = require('gulp'),
78

89
// node dependencies
@@ -14,7 +15,7 @@ let
1415
print = require('gulp-print').default,
1516

1617
// user config
17-
config = require('../config/docs'),
18+
configDocs = require('../config/docs'),
1819

1920
// install config
2021
tasks = require('../config/tasks'),
@@ -35,7 +36,8 @@ let
3536

3637
module.exports = function (callback) {
3738
// use a different config
38-
config = configSetup.addDerivedValues(config);
39+
const config = extend(true, {}, configDocs);
40+
configSetup.addDerivedValues(config);
3941

4042
// shorthand
4143
const globs = config.globs;

tasks/docs/serve.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Serve Docs
33
*******************************/
44
let
5+
extend = require('extend'),
56
gulp = require('gulp'),
67

78
// node dependencies
@@ -11,7 +12,7 @@ let
1112
print = require('gulp-print').default,
1213

1314
// user config
14-
config = require('../config/docs'),
15+
configDocs = require('../config/docs'),
1516

1617
// task config
1718
tasks = require('../config/tasks'),
@@ -27,7 +28,8 @@ let
2728

2829
module.exports = function () {
2930
// use a different config
30-
config = configSetup.addDerivedValues(config);
31+
const config = extend(true, {}, configDocs);
32+
configSetup.addDerivedValues(config);
3133

3234
console.clear();
3335
console.log('Watching source files for changes');

0 commit comments

Comments
 (0)