Skip to content

Commit 0e39857

Browse files
authored
fix(dropdown): clearable icon was missing or misaligned
clearable icon ... was missing when used inside a search selection dropdown was misaligned when used inside an inline dropdown The basic fixes where already implemented but only if the clearable class was set manually, which this PR now automatically adds when the clearable setting is used.
1 parent a5363fb commit 0e39857

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/definitions/modules/dropdown.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3468,7 +3468,12 @@
34683468
return $selectedMenu.hasClass(className.leftward);
34693469
},
34703470
clearable: function () {
3471-
return $module.hasClass(className.clearable) || settings.clearable;
3471+
var hasClearableClass = $module.hasClass(className.clearable);
3472+
if (!hasClearableClass && settings.clearable) {
3473+
$module.addClass(className.clearable);
3474+
}
3475+
3476+
return hasClearableClass || settings.clearable;
34723477
},
34733478
disabled: function () {
34743479
return $module.hasClass(className.disabled);

src/definitions/modules/dropdown.less

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -811,14 +811,14 @@ select.ui.dropdown {
811811
}
812812
}
813813

814-
.ui.clearable.dropdown .text,
815-
.ui.clearable.dropdown a:last-of-type {
814+
.ui.clearable.dropdown .text:not(.default),
815+
.ui.clearable.dropdown:not(.search) > .ui.label:last-of-type {
816816
margin-right: @clearableTextMargin;
817817
}
818818

819819
.ui.dropdown select.noselection ~ .remove.icon,
820820
.ui.dropdown input[value=""] ~ .remove.icon,
821-
.ui.dropdown input:not([value]) ~ .remove.icon,
821+
.ui.dropdown input:not([value]):not(.search) ~ .remove.icon,
822822
.ui.dropdown.loading > .remove.icon {
823823
display: none;
824824
}

0 commit comments

Comments
 (0)