convert '%s' use to %q for error handling in EvaluateString

Signed-off-by: kathleen french <[email protected]>

Author: kathleenfrench

runtime/cel/expression.go

@@ -141,11 +141,11 @@ func (e *Expression) EvaluateBoolean(ctx context.Context, data map[string]any) (
 func (e *Expression) EvaluateString(ctx context.Context, data map[string]any) (string, error) {
 	val, _, err := e.prog.ContextEval(ctx, data)
 	if err != nil {
-		return "", fmt.Errorf("failed to evaluate the CEL expression '%s': %w", e.expr, err)
+		return "", fmt.Errorf("failed to evaluate the CEL expression %q: %w", e.expr, err)
 	}
 	result, ok := val.(types.String)
 	if !ok {
-		return "", fmt.Errorf("failed to evaluate CEL expression as string: '%s'", e.expr)
+		return "", fmt.Errorf("failed to evaluate CEL expression as string: %q", e.expr)
 	}
 	return string(result), nil
 }

runtime/cel/expression_test.go

@@ -233,7 +233,7 @@ func TestExpression_EvaluateString(t *testing.T) {
 			name: "non-existent field",
 			expr: "foo",
 			data: map[string]any{},
-			err:  "failed to evaluate the CEL expression 'foo': no such attribute(s): foo",
+			err:  `failed to evaluate the CEL expression "foo": no such attribute(s): foo`,
 		},
 		{
 			name:   "string field",
@@ -245,7 +245,7 @@ func TestExpression_EvaluateString(t *testing.T) {
 			name: "non-string field",
 			expr: "foo",
 			data: map[string]any{"foo": 123},
-			err:  "failed to evaluate CEL expression as string: 'foo'",
+			err:  `failed to evaluate CEL expression as string: "foo"`,
 		},
 		{
 			name:   "nested string field",
@@ -336,7 +336,7 @@ func TestExpression_EvaluateString(t *testing.T) {
 			data: map[string]any{
 				"foo": map[string]any{"bar": "hello-world-testing-123"},
 			},
-			err: "failed to evaluate CEL expression as string: 'foo.bar.split('-').first()'",
+			err: `failed to evaluate CEL expression as string: "foo.bar.split('-').first()"`,
 		},
 	} {
 		t.Run(tt.name, func(t *testing.T) {