Skip to content

Commit d4e54fe

Browse files
authored
Merge pull request #1242 from aryan9600/fix-hpa-fallback
Fix fallback logic for HPAv2 to v2beta2
2 parents 80bae41 + a5c284c commit d4e54fe

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pkg/canary/hpa_reconciler.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ func (hr *HPAReconciler) reconcilePrimaryHpa(cd *flaggerv1.Canary, init bool) er
3838
var betaHpa *hpav2beta2.HorizontalPodAutoscaler
3939
hpa, err := hr.kubeClient.AutoscalingV2().HorizontalPodAutoscalers(cd.Namespace).Get(context.TODO(), cd.Spec.AutoscalerRef.Name, metav1.GetOptions{})
4040
if err != nil {
41-
hr.logger.Debugf("v2 HorizontalPodAutoscaler %s.%s get query error: %w; falling back to v2beta2",
41+
hpa = nil
42+
hr.logger.Debugf("v2 HorizontalPodAutoscaler %s.%s get query error: %s; falling back to v2beta2",
4243
cd.Namespace, cd.Spec.AutoscalerRef.Name, err)
4344
var betaErr error
4445
betaHpa, betaErr = hr.kubeClient.AutoscalingV2beta2().HorizontalPodAutoscalers(cd.Namespace).Get(context.TODO(), cd.Spec.AutoscalerRef.Name, metav1.GetOptions{})

0 commit comments

Comments
 (0)