treat 204 from FAN as a no bids response (prebid#1233)

Co-authored-by: Aadesh Patel <[email protected]>

Author: Aadeshp

adapters/audienceNetwork/audienceNetworktest/supplemental/no-bid-204.json

@@ -0,0 +1,91 @@
+{
+    "mockBidRequest": {
+        "id": "test-req-id",
+        "imp": [
+            {
+                "id": "test-imp-id",
+                "native": {
+                    "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"plcmttype\":4,\"plcmtcnt\":1,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}",
+                    "ver": "1.1"
+                },
+                "ext": {
+                    "bidder": {
+                        "publisherid": "123",
+                        "placementid": "456"
+                    }
+                }
+            }
+        ],
+        "site": {
+            "domain": "prebid.org",
+            "page": "prebid.org"
+        },
+        "device": {
+            "ip": "152.193.6.74"
+        },
+        "user": {
+            "id": "db089de9-a62e-4861-a881-0ff15e052516",
+            "buyeruid": "v4_bidder_token"
+        },
+        "tmax": 500
+    },
+    "httpcalls": [
+        {
+            "expectedRequest": {
+                "uri": "https://an.facebook.com/placementbid.ortb",
+                "headers": {
+                    "Accept": [
+                        "application/json"
+                    ],
+                    "Content-Type": [
+                        "application/json;charset=utf-8"
+                    ],
+                    "X-Fb-Pool-Routing-Token": [
+                        "v4_bidder_token"
+                    ]
+                },
+                "body": {
+                    "id": "test-req-id",
+                    "imp": [
+                        {
+                            "id": "test-imp-id",
+                            "native": {
+                                "w": -1,
+                                "h": -1
+                            },
+                            "tagid": "123_456"
+                        }
+                    ],
+                    "ext": {
+                        "appnexus": {
+                            "hb_source": 5
+                        },
+                        "prebid": {}
+                    },
+                    "site": {
+                        "domain": "prebid.org",
+                        "page": "prebid.org",
+                        "publisher": {
+                            "id": "123"
+                        }
+                    },
+                    "device": {
+                        "ip": "152.193.6.74"
+                    },
+                    "user": {
+                        "id": "db089de9-a62e-4861-a881-0ff15e052516",
+                        "buyeruid": "v4_bidder_token"
+                    },
+                    "tmax": 500,
+                    "ext": {
+                        "authentication_id": "b2f9edfd707106adb6b692520081ad7e2a345444af1a895310228297a1b6247e",
+                        "platformid": "test-platform-id"
+                    }
+                }
+            },
+            "mockResponse": {
+                "status": 204
+            }
+        }
+    ]
+}

adapters/audienceNetwork/facebook.go

@@ -333,6 +333,12 @@ func modifyImpCustom(json []byte, imp *openrtb.Imp) ([]byte, error) {
 }
 
 func (this *FacebookAdapter) MakeBids(request *openrtb.BidRequest, adapterRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
+	/* No bid response */
+	if response.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	/* Any other http status codes outside of 200 and 204 should be treated as errors */
 	if response.StatusCode != http.StatusOK {
 		msg := response.Headers.Get("x-fb-an-errors")
 		return nil, []error{&errortypes.BadInput{