Skip to content

Commit b911b36

Browse files
authored
Amend loadtesting readme (#16981)
#16423. Instructions were wrong, this is the way.
1 parent e71cdf7 commit b911b36

File tree

1 file changed

+3
-2
lines changed
  • infrastructure/loadtesting/terraform

1 file changed

+3
-2
lines changed

infrastructure/loadtesting/terraform/readme.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,12 @@ Following are the steps to deploy new code changes to osquery-perf (known as `lo
119119
> The following is to add new hosts with new/modified osquery-perf code. (This happens if during a load test
120120
> the developer realizes there's bug in osquery-perf or if it's not simulating osquery properly.)
121121
122-
> You don't need to push code changes because the `loadtest` image is built locally from your fleet repository source code.
122+
> You must push your code changes to the `$BRANCH_NAME`.
123123
124124
1. Bring all `loadtest` containers to `0` by running terraform apply with `loadtest_containers=0`.
125125
1. Delete all existing hosts (by selecting all on the UI).
126-
1. Delete all your local `loadtest` images, the image tags are of the form: `loadtest-$BRANCH_NAME-$TAG`.
126+
1. Delete all your local `loadtest` images, the image tags are of the form: `loadtest-$BRANCH_NAME-$TAG` (these are the `loadtest` images pushed to ECR). (Use `docker image list` to get their `IMAGE ID` and then run `docker rmi -f $ID`.)
127+
1. Delete local images of the form `REPOSITORY=<none>` and `TAG=<none>` that were built recently (these are the builder images). (Use `docker image list` to get their `IMAGE ID` and then run `docker rmi -f $ID`.)
127128
1. Log in to Amazon ECR (Elastic Container Registry) and delete the corresponding `loadtest` image.
128129
1. By executing the `terraform apply` with `-loadtest_containers=N` it will trigger a rebuild of the `loadtest` image.
129130

0 commit comments

Comments
 (0)