Skip to content

Commit 4ded49f

Browse files
committed
Take safer approach to add the comment to empty command-line flags
1 parent ad913b2 commit 4ded49f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

frontend/utilities/yaml/index.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,14 @@ export const agentOptionsToYaml = (agentOpts: any) => {
2222
!agentOpts.command_line_flags ||
2323
Object.keys(agentOpts.command_line_flags).length === 0
2424
) {
25-
agentOpts.command_line_flags = {};
25+
// delete it so it does not render, and will add it explicitly after (along with the comment)
26+
delete agentOpts.command_line_flags;
2627
addFlagsComment = true;
2728
}
2829

2930
let yamlString = yaml.dump(agentOpts);
3031
if (addFlagsComment) {
31-
yamlString = yamlString.replace(
32-
"command_line_flags: {}\n",
33-
"command_line_flags: {} # requires Orbit\n"
34-
);
32+
yamlString += "command_line_flags: {} # requires Orbit\n";
3533
}
3634

3735
return yamlString;

0 commit comments

Comments
 (0)