Skip to content

Commit 281b5ff

Browse files
authored
Rachael is API design DRI (#17630)
- Move "API design" DRI from "Product groups" page to DRIs table
1 parent 9f7fb1f commit 281b5ff

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

handbook/company/communications.md

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ We track competitors' capabilities and adjacent (or commonly integrated) product
2121
| Engineering output and architecture | [Luke Heath](https://www.linkedin.com/in/lukeheath/) _([@lukeheath](https://github.com/lukeheath))_ |
2222
| Structure and intentionallity of the [Docs](https://fleetdm.com/docs/get-started/why-fleet)| [Mike Thomas](https://www.linkedin.com/in/mike-thomas-52277938) _([@mike-j-thomas](https://github.com/mike-j-thomas))_ |
2323
| Design and content of the [Docs](https://fleetdm.com/docs/get-started/why-fleet) | [Rachael Shaw](https://www.linkedin.com/in/rachaelcshaw/) _([@rachaelshaw](https://github.com/rachaelshaw))_ |
24+
| API design | [Rachael Shaw](https://www.linkedin.com/in/rachaelcshaw/) _([@rachaelshaw](https://github.com/rachaelshaw))_ |
2425

2526

2627
### Docs

handbook/company/product-groups.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,7 @@ For product changes that cause breaking API or configuration changes or major im
8888
That all happens prior to work getting prioritized for the change.
8989

9090
#### API changes
91-
To maintain consistency, ensure perspective, and provide a single pair of eyes in the design of Fleet's REST API and API documentation, there is a single Directly Responsible Individual (DRI). The API design DRI will review and approve any alterations at the pull request stage, instead of making it a prerequisite during drafting of the story. You may tag the DRI in a GitHub issue with draft API specs in place to receive a review and feedback prior to implementation. Receiving a pre-review from the DRI is encouraged if the API changes introduce new endpoints, or substantially change existing endpoints.
92-
93-
> DRI: Rachael Shaw
91+
To maintain consistency, ensure perspective, and provide a single pair of eyes in the design of Fleet's REST API and API documentation, there is a single Directly Responsible Individual (DRI). The API design DRI will review and approve any alterations at the pull request stage, instead of making it a prerequisite during drafting of the story. You may tag the DRI in a GitHub issue with draft API specs in place to receive a review and feedback prior to implementation. Receiving a pre-review from the DRI is encouraged if the API changes introduce new endpoints, or substantially change existing endpoints.
9492

9593
No API changes are merged without accompanying API documentation and approval from the DRI. The DRI is responsible for ensuring that the API design remains consistent and adequately addresses both standard and edge-case scenarios. The DRI is also the code owner of the API documentation Markdown file. The DRI is committed to reviewing PRs within one business day. In instances where the DRI is unavailable, the Head of Product will act as the substitute code owner and reviewer.
9694

0 commit comments

Comments
 (0)