Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate log lines with hook output on v1.4.15 #675

Closed
vladimirfx opened this issue Oct 23, 2024 · 3 comments · Fixed by #677
Closed

Duplicate log lines with hook output on v1.4.15 #675

vladimirfx opened this issue Oct 23, 2024 · 3 comments · Fixed by #677

Comments

@vladimirfx
Copy link

Expected behavior (what you expected to happen):

Each hook stdout/stderr output should be logged once.

Actual behavior (what actually happened):

There are many full and partial duplicates on hook output in logs.

Steps to reproduce:

  1. Print something (maybe multiline or stderr) from a hook script
  2. See pod logs

Environment:

  • Shell-operator version: 1.4.15
  • Kubernetes version: 1.30.5
  • Installation type (kubectl apply, helm chart, etc.): Flux

Anything else we should know?:

controller.log

Additional information for debugging (if necessary):

https://github.com/cit-consulting/hetzner-failoverip-controller/blob/v0.8/docker/hooks/sync-fip.sh

@miklezzzz
Copy link
Contributor

Hello, could you please try adding -s flag to the curl calls in your script and give it a try?

@vladimirfx
Copy link
Author

vladimirfx commented Oct 24, 2024

@miklezzzz
Copy link
Contributor

Fixed in the linked PR.
Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants