Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl in the Docker images #141

Closed
brandonkal opened this issue Mar 12, 2020 · 2 comments
Closed

Update kubectl in the Docker images #141

brandonkal opened this issue Mar 12, 2020 · 2 comments
Milestone

Comments

@brandonkal
Copy link

kubectl is now four major versions behind. Please update it to the latest stable version. I'd love to start experimenting with this.

Also, tagging and releasing the first stage of this build would make it easier for others to choose the kubectl version they want.

@diafour
Copy link
Contributor

diafour commented Mar 13, 2020

Hello @brandonkal!

Please update it to the latest stable version.

I've updated kubectl to v1.17.4 and added alpine-3.11 build in PR #146.

Also, tagging and releasing the first stage of this build would make it easier for others to choose the kubectl version they want.

Can you be more specific, what kind of image that will be? A scratch image with shell-operator binary or something else?

One can replace kubectl binary in image with just one RUN command:

FROM flant/shell-operator:latest
RUN wget https://storage.googleapis.com/kubernetes-release/release/v1.17.4/bin/linux/amd64/kubectl -O /bin/kubectl && \
    chmod +x /bin/kubectl
ADD hooks /hooks

I replace shell-operator binary for testing purposes in that manner. Is it a suitable solution for your task?

@brandonkal
Copy link
Author

brandonkal commented Mar 13, 2020

Thank you for the update. Regarding my second request, now that I think about it, it wouldn't make much sense to publish the go build container with the shell-operator binary.

A scratch container with the binary would probably be more interesting simply as a means to fetch only the built binary. But that is not really necessary now as the size of flant/shell-operator image is already pretty slim.

@diafour diafour added this to the 1.0.0-beta.9 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants