Skip to content

Commit e4f317f

Browse files
ldmonsterPavel Okhlopkov
and
Pavel Okhlopkov
authored
change pipe writer for buffer (#674)
Signed-off-by: Pavel Okhlopkov <[email protected]> Co-authored-by: Pavel Okhlopkov <[email protected]>
1 parent 054615d commit e4f317f

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

pkg/executor/executor.go

+12-9
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,10 @@ func RunAndLogLines(cmd *exec.Cmd, logLabels map[string]string) (*CmdUsage, erro
3939

4040
logEntry.Debugf("Executing command '%s' in '%s' dir", strings.Join(cmd.Args, " "), cmd.Dir)
4141

42-
if app.LogProxyHookJSON {
43-
plo := &proxyJSONLogger{stdoutLogEntry, make([]byte, 0)}
44-
ple := &proxyJSONLogger{stderrLogEntry, make([]byte, 0)}
45-
cmd.Stdout = plo
46-
cmd.Stderr = io.MultiWriter(ple, stdErr)
47-
} else {
48-
cmd.Stdout = stdoutLogEntry.Writer()
49-
cmd.Stderr = io.MultiWriter(stderrLogEntry.Writer(), stdErr)
50-
}
42+
plo := &proxyJSONLogger{stdoutLogEntry, make([]byte, 0), app.LogProxyHookJSON}
43+
ple := &proxyJSONLogger{stderrLogEntry, make([]byte, 0), app.LogProxyHookJSON}
44+
cmd.Stdout = plo
45+
cmd.Stderr = io.MultiWriter(ple, stdErr)
5146

5247
err := cmd.Run()
5348
if err != nil {
@@ -78,11 +73,19 @@ type proxyJSONLogger struct {
7873
*log.Entry
7974

8075
buf []byte
76+
77+
logProxyHookJSON bool
8178
}
8279

8380
func (pj *proxyJSONLogger) Write(p []byte) (n int, err error) {
8481
pj.buf = append(pj.buf, p...)
8582

83+
if !pj.logProxyHookJSON {
84+
pj.Entry.Log(log.InfoLevel, strings.TrimSpace(string(pj.buf)))
85+
86+
return len(p), nil
87+
}
88+
8689
var line interface{}
8790
err = json.Unmarshal(pj.buf, &line)
8891
if err != nil {

0 commit comments

Comments
 (0)