Skip to content

Remove innerWindowID from the frameTable once the active tab view is gone #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstange opened this issue May 2, 2025 · 0 comments
Open

Comments

@mstange
Copy link
Contributor

mstange commented May 2, 2025

The frameTable has an innerWindowID column so that we can determine, per sample, whether that sample was relevant for a given page. This is what we use in the active tab view to hide samples from other tabs.

But the active tab view is going to be removed (#4997).

The replacement doesn't do any filtering of samples. The motivation for this was two-fold:

  1. Firefox Desktop now puts separate origins into separate content processes ("Fission"), so by filtering processes, you also make sure that the remaining processes only contain relevant samples.
  2. Even if code from different pages runs in the same process, anything within a process can be relevant to slow performance, so it's better to just show it all.

This means that the innerWindowID information in the frameTable will be unnecessary. We will need another way to know which process is relevant to which page (#5442), but with that fixed, we should just remove the innerWindowID column from the frameTable entirely.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant