Address review comments

Author: gregtatum

docs-developer/loading-in-profiles.md

@@ -147,7 +147,7 @@ function openProfile(profile) {
 
   window.addEventListener('message', listener);
   while (!isReady) {
-    await new Promise((resolve) => setTimeout(resolve, 10));
+    await new Promise((resolve) => setTimeout(resolve, 100));
     profilerWindow.postMessage({ name: 'is-ready' }, origin);
   }
 
@@ -162,8 +162,6 @@ await waitForProfilerReady();
 window.postMessage({ name: 'inject-profile', profile }, '*');
 ```
 
-This
-
 ### File
 
 > `https://profiler.firefox.com/from-file/`

src/actions/receive-profile.js

@@ -82,7 +82,6 @@ import type {
   InnerWindowID,
   Pid,
   OriginsTimelineRoot,
-  DataSource,
 } from 'firefox-profiler/types';
 
 import type {
@@ -127,7 +126,6 @@ export function loadProfile(
     transformStacks: TransformStacksPerThread,
     browserConnection: BrowserConnection | null,
     skipSymbolication: boolean, // Please use this in tests only.
-    dataSource: DataSource,
   |}> = {},
   initialLoad: boolean = false
 ): ThunkAction<Promise<void>> {
@@ -157,7 +155,6 @@ export function loadProfile(
       pathInZipFile: config.pathInZipFile,
       implementationFilter: config.implementationFilter,
       transformStacks: config.transformStacks,
-      dataSource: config.dataSource,
     });
 
     // During initial load, we are upgrading the URL and generating the UrlState
@@ -716,7 +713,6 @@ export function viewProfile(
     transformStacks: TransformStacksPerThread,
     skipSymbolication: boolean,
     browserConnection: BrowserConnection | null,
-    dataSource: DataSource,
   |}> = {}
 ): ThunkAction<Promise<void>> {
   return async (dispatch) => {
@@ -1659,6 +1655,11 @@ export function retrieveProfileForRawUrl(
               dispatch(viewProfileFromPostMessage(data.profile));
               break;
             case 'is-ready': {
+              // The "inject-profile" event could be coming from a variety of locations.
+              // It could come from a `window.open` call on another page. It could come
+              // from an addon. It could come from being embedded in an iframe. In order
+              // to generically support these cases allow the opener to poll for the
+              // "is-ready" message.
               console.log(
                 'Responding via postMessage that the profiler is ready.'
               );

src/reducers/url-state.js

@@ -54,8 +54,6 @@ const dataSource: Reducer<DataSource> = (state = 'none', action) => {
       return 'unpublished';
     case 'SET_DATA_SOURCE':
       return action.dataSource;
-    case 'PROFILE_LOADED':
-      return action.dataSource ?? state;
     default:
       return state;
   }

src/test/components/UrlManager.test.js

@@ -334,8 +334,7 @@ describe('UrlManager', function () {
     const { getState, waitUntilUrlSetupPhase, createUrlManager } = setup(
       '/from-post-message/'
     );
-    const log = console.log;
-    (console: any).log = jest.fn();
+    jest.spyOn(console, 'log').mockImplementation(() => {});
 
     expect(getProfileOrNull(getState())).toBeFalsy();
 
@@ -368,8 +367,5 @@ describe('UrlManager', function () {
     await new Promise((resolve) => setTimeout(resolve, 0));
 
     expect(getProfileOrNull(getState())).toBeTruthy();
-
-    // Restore the console.log.
-    (console: any).log = log;
   });
 });

src/test/store/symbolication.test.js

@@ -484,7 +484,6 @@ describe('doSymbolicateProfile', function () {
       implementationFilter: undefined,
       pathInZipFile: undefined,
       transformStacks: undefined,
-      dataSource: undefined,
     });
     profile = ProfileViewSelectors.getProfile(getState());
     expect(profile).toBe(newProfile);

src/types/actions.js

@@ -400,7 +400,6 @@ type ReceiveProfileAction =
       +pathInZipFile: ?string,
       +implementationFilter: ?ImplementationFilter,
       +transformStacks: ?TransformStacksPerThread,
-      +dataSource: ?DataSource,
     |}
   | {|
       +type: 'VIEW_FULL_PROFILE',