v1.18: deprecate get_client and get_multi_client (backport of anza-xyz#177) (anza-xyz#182)

mergify[bot] · gregcusack · willhickey · commit 1f3917a26cc9 · 2024-03-13T10:21:54.000-05:00
* deprecate `get_client` and `get_multi_client` (anza-xyz#177) deprecate get_client and get_multi_client (cherry picked from commit 00c984f) * bump deprecated version numbers --------- Co-authored-by: Greg Cusack <greg.cusack@anza.xyz>
diff --git a/bench-tps/src/main.rs b/bench-tps/src/main.rs
@@ -1,4 +1,5 @@
 #![allow(clippy::arithmetic_side_effects)]
+#![allow(deprecated)]
 use {
     clap::value_t,
     log::*,
diff --git a/dos/src/main.rs b/dos/src/main.rs
@@ -39,6 +39,7 @@
 //! ```
 //!
 #![allow(clippy::arithmetic_side_effects)]
+#![allow(deprecated)]
 use {
     crossbeam_channel::{select, tick, unbounded, Receiver, Sender},
     itertools::Itertools,
diff --git a/gossip/src/gossip_service.rs b/gossip/src/gossip_service.rs
@@ -193,6 +193,7 @@ pub fn discover(
 }
 
 /// Creates a ThinClient by selecting a valid node at random
+#[deprecated(since = "1.18.6", note = "Interface will change")]
 pub fn get_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,
@@ -208,6 +209,7 @@ pub fn get_client(
     ThinClient::new(rpc, tpu, connection_cache)
 }
 
+#[deprecated(since = "1.18.6", note = "Will be removed in favor of get_client")]
 pub fn get_multi_client(
     nodes: &[ContactInfo],
     socket_addr_space: &SocketAddrSpace,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#![allow(clippy::arithmetic_side_effects)]`
	`2`	`+#![allow(deprecated)]`
`2`	`3`	`use {`
`3`	`4`	`clap::value_t,`
`4`	`5`	`log::*,`
Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,7 @@ pub fn discover(`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`/// Creates a ThinClient by selecting a valid node at random`
	`196`	`+#[deprecated(since = "1.18.6", note = "Interface will change")]`
`196`	`197`	`pub fn get_client(`
`197`	`198`	`nodes: &[ContactInfo],`
`198`	`199`	`socket_addr_space: &SocketAddrSpace,`
`@@ -208,6 +209,7 @@ pub fn get_client(`
`208`	`209`	`ThinClient::new(rpc, tpu, connection_cache)`
`209`	`210`	`}`
`210`	`211`
	`212`	`+#[deprecated(since = "1.18.6", note = "Will be removed in favor of get_client")]`
`211`	`213`	`pub fn get_multi_client(`
`212`	`214`	`nodes: &[ContactInfo],`
`213`	`215`	`socket_addr_space: &SocketAddrSpace,`