Remove deprecated jobruns endpoint

Author: fieldryand

goflow_test.go

@@ -71,16 +71,6 @@ func TestJobsRoute(t *testing.T) {
 	}
 }
 
-func TestJobRunsRoute(t *testing.T) {
-	var w = httptest.NewRecorder()
-	req, _ := http.NewRequest("GET", "/api/jobruns", nil)
-	router.ServeHTTP(w, req)
-
-	if w.Code != http.StatusOK {
-		t.Errorf("httpStatus is %d, expected %d", w.Code, http.StatusOK)
-	}
-}
-
 func TestExecutionsRoute(t *testing.T) {
 	var w = httptest.NewRecorder()
 	req, _ := http.NewRequest("GET", "/api/executions", nil)

routes.go

@@ -54,48 +54,6 @@ func (g *Goflow) addAPIRoutes() *Goflow {
 			c.JSON(http.StatusOK, msg)
 		})
 
-		// Deprecated: will be removed in v3.0.0
-		api.GET("/jobruns", func(c *gin.Context) {
-			jobName := c.Query("jobname")
-			stateQuery := c.Query("state")
-
-			jobruns := make([]jobrun, 0)
-
-			for job := range g.Jobs {
-				stored, _ := readExecutions(g.Store, job)
-				for _, execution := range stored {
-					if stateQuery != "" && stateQuery != string(execution.State) {
-					} else if jobName != "" && jobName != execution.JobName {
-					} else {
-
-						t := taskstate{make(map[string]state, 0)}
-
-						for _, task := range execution.TaskExecutions {
-							t.Taskstate[task.Name] = task.State
-						}
-
-						j := jobrun{
-							JobName:   job,
-							Submitted: execution.StartedAt,
-							JobState: jobstate{
-								State:     execution.State,
-								TaskState: t,
-							},
-						}
-
-						jobruns = append(jobruns, j)
-					}
-				}
-			}
-
-			var msg struct {
-				Jobruns []jobrun `json:"jobruns"`
-			}
-			msg.Jobruns = jobruns
-
-			c.JSON(http.StatusOK, msg)
-		})
-
 		api.GET("/executions", func(c *gin.Context) {
 			jobName := c.Query("jobname")
 			stateQuery := c.Query("state")

swagger.json

@@ -119,67 +119,6 @@
         }
       }
     },
-    "/api/jobruns": {
-      "get": {
-        "operationId": "listJobRuns",
-        "summary": "query and list job runs",
-        "parameters": [
-          {
-            "in": "query",
-            "name": "jobname",
-            "schema": {
-              "type": "string"
-            },
-            "description": "(optional) the job name"
-          },
-          {
-            "in": "query",
-            "name": "state",
-            "schema": {
-              "type": "string"
-            },
-            "description": "(optional) the job state, valid values are [running, failed, successful]"
-          }
-        ],
-        "responses": {
-          "200": {
-            "description": "200 response",
-            "content": {
-              "application/json": {
-                "examples": {
-                  "exampleJobRuns": {
-                    "value": {
-                      "jobruns": [
-                        {
-                          "job": "exampleComplexAnalytics",
-                          "submitted": "2023-06-24T07:23:11.208506156Z",
-                          "state": {
-                            "job": "running",
-                            "tasks": {
-                              "state": {
-                                "addOneOne": "running",
-                                "addThreeFour": "notstarted",
-                                "addTwoFour": "notstarted",
-                                "cleanUp": "notstarted",
-                                "sleepOne": "successful",
-                                "sleepTwo": "notstarted",
-                                "totallySkippable": "notstarted",
-                                "whoopsWithConstantDelay": "running",
-                                "whoopsWithExponentialBackoff": "upforretry"
-                              }
-                            }
-                          }
-                        }
-                      ]
-                    }
-                  }
-                }
-              }
-            }
-          }
-        }
-      }
-    },
     "/api/executions": {
       "get": {
         "operationId": "listExecutions",
@@ -208,7 +147,7 @@
             "content": {
               "application/json": {
                 "examples": {
-                  "exampleJobRuns": {
+                  "exampleExecutions": {
                     "value": {
                       "executions": [
                         {