chore: linting -d

Author: arpowers

.gitignore

@@ -35,6 +35,7 @@ wire.*
 
 # Debugging
 .ts-node
+.eslintcache
 *.log
 chrome_debug.log
 heap*

.vscode/settings.json

@@ -1,5 +1,7 @@
 {
-
+  "git.enableSmartCommit": true,
+  "git.autofetch": true,
+  "git.confirmSync": false,
   "prettier.proseWrap": "always",
   "editor.largeFileOptimizations": true,
   // Enable the ESlint flat config support
@@ -13,7 +15,8 @@
     "**/node_modules/**",
     "**/.hg/**",
     "**/.svn/**",
-    "**/*.test.*"
+    "**/*.test.*",
+    ".eslintcache"
   ],
   // Auto fix
   "editor.codeActionsOnSave": {
@@ -58,10 +61,11 @@
     { "rule": "*semi", "severity": "off", "fixable": true }
   ],
   "search.exclude": {
+    "**/node_modules": true,
+    "**/dist": true,
     "**/.fiction/**": true,
     "**/.ref*": true,
     "*.log": true,
-    "**/dist": true,
     "node_modules": true,
     "coverage": true,
     "**/CHANGELOG.md": true,
@@ -75,8 +79,13 @@
     "**/*.svg": true,
     "**/stats.html": true
   },
-  "files.exclude": {},
+  "files.exclude": {
+    "**/node_modules": true,
+    "**/dist": true
+  },
   "files.watcherExclude": {
+    "**/node_modules/**": true,
+    "**/dist/**": true,
     "**/.git/objects/**": true,
     "**/.git/subtree-cache/**": true,
     "**/node_modules/*/**": true,

@fiction/admin/package.json

@@ -11,7 +11,7 @@
     "animejs": "^3.2.2",
     "mapbox-gl": "^3.6.0",
     "tailwindcss": "^3.4.11",
-    "vue": "^3.5.4"
+    "vue": "^3.5.5"
   },
   "devDependencies": {
     "@types/animejs": "^3.1.12",

@fiction/admin/tools/ElToolHandle.vue

@@ -3,7 +3,7 @@ import type { Handle } from './tools'
 import { vue } from '@fiction/core'
 import TransitionSlide from '@fiction/ui/anim/TransitionSlide.vue'
 
-const props = defineProps({
+defineProps({
   handle: { type: Object as vue.PropType<Handle>, required: true },
 })
 

@fiction/analytics/tag/test/analyticsTrack.unit.test.ts

@@ -1,12 +1,13 @@
+/* eslint-disable ts/unbound-method */
 /**
  * @vitest-environment happy-dom
  */
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
-import { AnalyticsTag } from '../tagAnalytics' // Replace with the actual file name
-import { historyUtil } from '../../utils/history'
+import { historyUtil } from '../../utils/history' // Replace with the actual file name
 import { FictionPageStats } from '../../utils/pageStats'
 import { UnloadUtility } from '../../utils/tracking'
 import { FictionClient } from '../client'
+import { AnalyticsTag } from '../tagAnalytics'
 
 describe('analyticsTag', () => {
   let analyticsTag: AnalyticsTag

@fiction/analytics/test/client.stats.test.ts

@@ -39,7 +39,7 @@ describe('tracking client', async () => {
   it('should transmit event data synchronously', async () => {
     const event = client.createTrackingEvent({ event: 'syncEvent' })
     const spy = vi.spyOn(client as any, 'transmitSync')
-    client.event({ event: 'syncEvent' }, { sync: true })
+    await client.event({ event: 'syncEvent' }, { sync: true })
     await waitFor(20) // events are buffered
     expect(spy).toHaveBeenCalled()
     expect(spy).toHaveBeenCalledWith(expect.objectContaining({ events: [

@fiction/analytics/utils/test/clickTrack.unit.test.ts

@@ -6,7 +6,8 @@ import { clickId, elementId } from '../tracking'
 
 // Mock the getSelector function
 vi.mock('../tracking', async (importOriginal) => {
-  const mod = (await importOriginal())
+  // eslint-disable-next-line ts/no-unnecessary-type-assertion
+  const mod = (await importOriginal()) as Record<string, unknown>
   return {
     ...mod,
     getSelector: vi.fn().mockImplementation(() => 'div.test-class'),

@fiction/cards/insta/ElCard.vue

@@ -7,10 +7,10 @@ const props = defineProps({
   card: { type: Object as vue.PropType<Card<UserConfig, { requests: CardRequests }>>, required: true },
 })
 
-const vis = vue.ref(false)
+const _vis = vue.ref(false)
 
 vue.onMounted(async () => {
-  const x = props.card.request('instagram', { test: true })
+  const _x = props.card.request('instagram', { test: true })
 })
 </script>
 

@fiction/cards/magazine/index.ts

@@ -1,4 +1,3 @@
-import type { Site } from '@fiction/site'
 import type { SiteUserConfig } from '@fiction/site/schema'
 import { PostHandlingSchema, safeDirname, vue } from '@fiction/core'
 import { cardTemplate } from '@fiction/site'
@@ -25,7 +24,7 @@ async function getDefaultUserConfig(): Promise<UserConfig> {
   }
 }
 
-async function getDemoUserConfig(args: { site?: Site }): Promise<UserConfig> {
+async function getDemoUserConfig(): Promise<UserConfig> {
   const c: UserConfig = {
     standard: { spacing: { verticalSpacing: 'sm' } },
     posts: {
@@ -119,8 +118,8 @@ export const templates = [
     isPublic: false,
     options,
     schema,
-    demoPage: async (args) => {
-      const demoUserConfig = await getDemoUserConfig(args)
+    demoPage: async () => {
+      const demoUserConfig = await getDemoUserConfig()
       const defaultUserConfig = await getDefaultUserConfig()
       return {
         cards: [

@fiction/cards/package.json

@@ -12,7 +12,7 @@
     "animejs": "^3.2.2",
     "mapbox-gl": "^3.6.0",
     "tailwindcss": "^3.4.11",
-    "vue": "^3.5.4"
+    "vue": "^3.5.5"
   },
   "devDependencies": {
     "@types/animejs": "^3.1.12",

@fiction/cards/postGrid/index.ts

@@ -39,6 +39,7 @@ export const templates = [
     colorTheme: 'green',
     el: vue.defineAsyncComponent(async () => import('./ElCard.vue')),
     options,
+    schema,
     isPublic: false,
     getUserConfig: async () => defaultConfig(),
     demoPage: async () => {

@fiction/cards/textEffects/ElCard.vue

@@ -16,7 +16,7 @@ async function applyAnimatedUnderline() {
 
 vue.onMounted(async () => {
   await waitFor(100)
-  vue.watch(() => fictionRouter.current.value, async (r) => {
+  vue.watch(() => fictionRouter.current.value, async () => {
     // Reset and reapply animations on route change
     await waitFor(100) // Short delay to ensure DOM is updated
     applyAnimatedUnderline()

@fiction/core/package.json

@@ -37,8 +37,8 @@
     "@unhead/vue": "^1.11.2",
     "@vitejs/plugin-vue": "^5.1.3",
     "@vue-email/compiler": "^0.8.14",
-    "@vue/compiler-sfc": "^3.5.4",
-    "@vue/server-renderer": "^3.5.4",
+    "@vue/compiler-sfc": "^3.5.5",
+    "@vue/server-renderer": "^3.5.5",
     "autoprefixer": "^10.4.20",
     "axios": "^1.7.7",
     "bcrypt": "^5.1.1",
@@ -48,7 +48,7 @@
     "buffer-lite": "^2.1.0",
     "chalk": "^5.3.0",
     "chart.js": "^4.4.4",
-    "chokidar": "^3.6.0",
+    "chokidar": "^4.0.0",
     "cjs-module-lexer": "^1.4.1",
     "commander": "^12.1.0",
     "compression": "^1.7.4",
@@ -138,16 +138,16 @@
     "unhead": "^1.11.2",
     "uuid-apikey": "^1.5.3",
     "validator": "^13.12.0",
-    "vite": "^5.4.4",
-    "vue": "^3.5.4",
-    "vue-router": "^4.4.4",
+    "vite": "^5.4.5",
+    "vue": "^3.5.5",
+    "vue-router": "^4.4.5",
     "ws": "^8.18.0",
     "zod": "^3.23.8",
     "zod-to-json-schema": "^3.23.3"
   },
   "devDependencies": {
     "@babel/parser": "^7.25.6",
-    "@playwright/test": "^1.47.0",
+    "@playwright/test": "^1.47.1",
     "@tailwindcss/forms": "^0.5.9",
     "@types/bcrypt": "^5.0.2",
     "@types/body-parser": "^1.19.5",
@@ -175,11 +175,11 @@
     "@types/spark-md5": "^3.0.4",
     "@types/validator": "^13.12.1",
     "@types/ws": "^8.5.12",
-    "@vitest/ui": "^2.1.0",
+    "@vitest/ui": "^2.1.1",
     "deep-object-diff": "^1.1.9",
     "fake-indexeddb": "^6.0.0",
     "ngrok": "5.0.0-beta.2",
-    "playwright": "^1.47.0",
+    "playwright": "^1.47.1",
     "react-dom": "^18.3.1",
     "rollup": "^4.21.3",
     "rollup-plugin-visualizer": "^5.12.0",

@fiction/core/plugin-app/utils/vitePluginMarkdown.ts

@@ -52,6 +52,7 @@ class ParseHandler {
     const content = new ExportedContent()
 
     // RELATIVE IMAGE PATHS
+    // eslint-disable-next-line regexp/no-unused-capturing-group
     const imagePattern = /\.\.?\/[^\s)]+\.(jpg|jpeg|png|svg|gif|bmp|webp)/gi
 
     const resolvedCode = code.replaceAll(imagePattern, (match) => {

@fiction/core/plugin-db/objects.ts

@@ -107,7 +107,7 @@ export class FictionDbTable {
     else {
       this.log.info(`creating table: ${this.pgTableKey}`)
       const promise = new Promise<void>(async (resolve) => {
-        await db.schema.createTable(this.pgTableKey, async (t) => {
+        await db.schema.createTable(this.pgTableKey, async () => {
           await this.createColumns(db)
           resolve()
         })

@fiction/core/plugin-user/test/endpoint.org.unit.test.ts

@@ -5,7 +5,6 @@ import { describe, expect, it } from 'vitest'
 describe('org handling', async () => {
   const testUtils = createTestUtils()
   const initialized = await testUtils.init()
-  const orgId = initialized.user.orgs?.[0].orgId
 
   let workingUser: User | undefined
   let workingOrg: Organization | undefined

@fiction/core/plugin-user/test/user.unit.test.ts

@@ -84,7 +84,7 @@ describe('user tests', async () => {
 
     let triggered = false
 
-    testUtils.fictionUser.events.on('resetPassword', async (args) => {
+    testUtils.fictionUser.events.on('resetPassword', async (_args) => {
       triggered = true
     })
 

@fiction/core/test-utils/buildTest.ts

@@ -279,6 +279,26 @@ export async function performActions(args: {
                 await playwrightTest.expect(frameElement).toContainText(frameAction.text || '')
                 break
               }
+              case 'scrollTo':
+                await frameElement.scrollIntoViewIfNeeded()
+                break
+              case 'exists':
+                await frameElement.waitFor({ state: 'attached', timeout: 10000 })
+                expect(await frameElement.count(), `${frameAction.selector} exists in frame`).toBeGreaterThan(0)
+                break
+              case 'count':
+                await frameElement.waitFor({ state: 'attached', timeout: 10000 })
+                expect(await frameElement.count(), `${frameAction.selector} count in frame`).toBeGreaterThan(0)
+                break
+              case 'value': {
+                await waitFor(500)
+                const value = await frameElement.evaluate(el => el.dataset.value)
+                const v = value ? JSON.parse(value) : {}
+                frameAction.callback?.(v)
+                break
+              }
+              default:
+                throw new Error(`Unsupported frame action type: ${frameAction.type}`)
             }
           }
           break

@fiction/core/utils/url.ts

@@ -162,7 +162,7 @@ export function updateUrl({ url, newUrlOrPath }: { url: string, newUrlOrPath: st
     newUrlObj = new URL(p)
     urlObj = newUrlObj
   }
-  catch (e) {
+  catch {
     // If not a full URL, treat it as a pathname and construct a new URL with a dummy base
     const dummyBase = 'http://dummybase.com'
     newUrlObj = new URL(p, dummyBase)

@fiction/forms/endpoint.ts

@@ -1,8 +1,10 @@
 import type { DataFilter, EndpointMeta, EndpointResponse, IndexQuery } from '@fiction/core'
 import type { EmailResponse } from '@fiction/core/plugin-email/endpoint.js'
+import type { CardConfigPortable } from '@fiction/site/tables.js'
 import type { FictionForms, FormPluginSettings } from './index.js'
 import type { FormConfigPortable, FormSubmissionConfig } from './schema.js'
-import { Query } from '@fiction/core'
+import type { InputUserConfig } from './templates.js'
+import { isPlainObject, Query } from '@fiction/core'
 import { t } from './schema.js'
 
 type FormSubmissionSettings = {
@@ -189,12 +191,14 @@ export class QueryManageSubmission extends FormQuery {
 
       const heading = `${orgName}: New ${title || 'Form'} Submission`
 
-      const cards = card?.cards || []
+      const cards = (card?.cards || []) as CardConfigPortable<InputUserConfig>[]
 
       const formattedDetails = cards.filter(c => c.userConfig?.userValue).map((c) => {
         const uc = c.userConfig || {}
 
-        return `- **${uc.title}**: ${uc.userValue}`
+        const val = Array.isArray(uc.userValue) ? uc.userValue.join(', ') : isPlainObject(uc.userValue) ? JSON.stringify(uc.userValue) : uc.userValue as string
+
+        return `- **${uc.title}**: ${val}`
       },
       ).join('\n')
 
@@ -219,8 +223,10 @@ export class QueryManageSubmission extends FormQuery {
       const emails = await Promise.all(emailPromises)
 
       this.log.info('Email sent for new form submission', { data: { heading, bodyMarkdown } })
+      // eslint-disable-next-line ts/no-unnecessary-type-assertion
+      const data = (emails.map(e => e.data).filter(Boolean)) as EmailResponse[]
 
-      return { status: 'success', data: emails.map(e => e.data).filter(Boolean) }
+      return { status: 'success', data }
     }
     catch (error) {
       this.log.error('Failed to send email notification for new form submission', { error, data: params })

@fiction/forms/form.ts

@@ -102,7 +102,7 @@ export class Form extends FictionObject<FormSettings> {
     }
 
     if (nextCardId)
-      this.setActiveId({ cardId: nextCardId, drawer: 'toggle' })
+      await this.setActiveId({ cardId: nextCardId, drawer: 'toggle' })
   }
 
   async setActiveId(args: {

@fiction/forms/templates.ts

@@ -16,7 +16,7 @@ const inputSchema = z.object({
   buttonText: z.string().optional(),
   required: z.boolean().optional(),
   inputType: z.string().optional() as z.Schema<keyof typeof inputs | undefined>,
-  userValue: z.unknown().optional(),
+  userValue: z.union([z.string(), z.number(), z.record(z.string(), z.union([z.string(), z.number()]))]).optional(),
   media: z.object({
     url: z.string().optional(),
     format: z.enum(['url', 'image', 'video']).optional(),

@fiction/platform/index.ts

@@ -21,6 +21,6 @@ export interface CreateSiteSettings {
   isGlobalSetup?: boolean
 }
 
-export function createSite(opts?: CreateSiteSettings) {
+export function createSite(_opts?: CreateSiteSettings) {
   return { }
 }

@fiction/plugins/plugin-ai/package.json

@@ -3,9 +3,9 @@
     "@fiction/core": "workspace:*",
     "@fiction/plugin-unsplash": "workspace:*",
     "@pinecone-database/pinecone": "^3.0.3",
-    "openai": "^4.60.0",
+    "openai": "^4.60.1",
     "tailwindcss": "^3.4.11",
-    "vue": "^3.5.4"
+    "vue": "^3.5.5"
   },
   "gitHead": "b257411e1c6c32b52b444cc6f1518bf1bee1e480",
   "license": "MIT",

@fiction/plugins/plugin-extend/registry.ts

@@ -12,12 +12,12 @@ class RegistryPlugin extends FictionPlugin<ModuleConfig> {
     super(config.name, settings)
   }
 
-  async init(services: RegistryPlugin[]) {
+  async init(_services: RegistryPlugin[]) {
     // Initialize module with available services
   }
 }
 
-class ModuleRegistry {
+export class ModuleRegistry {
   private modules: Record<string, RegistryPlugin> = {}
   private moduleConfigs: Record<string, ModuleConfig> = {}