Skip to content

Adding the spin plugins inspect command #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

ThorstenHans
Copy link
Contributor

Allowing Spin users to print detailed information of plugins, before installing them on their machine

Usage

spin plugins inspect otel
otel: 0.1.2 (License: Apache-2.0)
https://github.com/fermyon/otel-plugin

A plugin to make working with OTel in Spin easy

Users can print detailed information of a plugin before installing it

Signed-off-by: Thorsten Hans <[email protected]>
@rylev rylev requested review from itowlson September 12, 2024 11:51
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay except for bikeshedding the name, but I do wonder if the stated purpose would be better served by adding the info into the existing list and search commands - by the time I know enough about a plugin to choose it as a subject for this command, I probably already have a decent sense of what it does. I don't have any objection to this going in, just a bit curious about how we see it fitting into a user journey.

@ThorstenHans
Copy link
Contributor Author

I do wonder if the stated purpose would be better served by adding the info into the existing list and search commands

IMO, we should not update the output of list and/or search commands. Especially the description field could lead to messing up the output if not truncated. If we truncate the description, it would lead to users invoking spin plugins show either way.

@itowlson itowlson merged commit 4fbf872 into spinframework:main Sep 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants