Skip to content

JOSS Review: Optional flag to plot (but not show) a Fermi surface #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andrew-S-Rosen opened this issue Mar 13, 2021 · 4 comments
Closed

Comments

@Andrew-S-Rosen
Copy link

Andrew-S-Rosen commented Mar 13, 2021

RE: openjournals/joss-reviews#3089

Describe the bug
Upon running ifermi plot, it appears that an .html file is generated and an attempt is made to view the plot. I think it would be nice to have an optional flag to generate the plot but not show it. In my case, I'm SSH'd into a Linux machine without x-forwarding, and the code calls a web browser that I can't actually view and have to manually cancel out of every time I generate a plot via the command line interface.

@Andrew-S-Rosen
Copy link
Author

Andrew-S-Rosen commented Mar 13, 2021

I got ahead of myself. I see that later in the docs there are other backends! Sorry! This is probably also related to #20 when using the Ubuntu subshell, where I didn't have a GUI or web browser.

@utf
Copy link
Collaborator

utf commented Mar 13, 2021

Also you can use --output filename.jpg to save a file rather generating an interactive plot.

Although, currently you can't do --output filename.html, so I think I will add that in for the plotly backend.

@Andrew-S-Rosen
Copy link
Author

The second case would be really useful to add, I think! You can't beat the interactiveness :)

@utf
Copy link
Collaborator

utf commented Mar 13, 2021

Ok, this has been added. Once you have finished your review I will push a new version with this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants