test: test coverage

Author: fent

lib/index.js

@@ -63,7 +63,7 @@ module.exports = (options) => {
       if (this._dest) {
         this._dest.stream.write(chunk, encoding, callback);
       } else {
-        this._destWritten.push(arguments);
+        this._destWritten.push([chunk, encoding, callback]);
       }
     }
 

test/error-test.js

@@ -0,0 +1,44 @@
+const streamify = require('..');
+const assert    = require('assert');
+
+
+describe('Errorneously call stream methods', () => {
+  describe('Call `stream.addSource()` with an existing source', () => {
+    it('Throws error', () => {
+      const stream = streamify();
+      stream.addSource(streamify());
+      assert.throws(() => {
+        stream.addSource(streamify());
+      }, /source stream has already been added/);
+    });
+  });
+
+  describe('Call `stream.addDest()` with an existing dest', () => {
+    it('Throws error', () => {
+      const stream = streamify();
+      stream.addDest(streamify());
+      assert.throws(() => {
+        stream.addDest(streamify());
+      }, /destination stream has already been added/);
+    });
+  });
+
+  describe('Call `stream.removeSource()` without adding one', () => {
+    it('Throws error', () => {
+      const stream = streamify();
+      assert.throws(() => {
+        stream.removeSource();
+      }, /source stream has not been added/);
+    });
+  });
+
+  describe('Call `stream.removeDest()` without adding one', () => {
+    it('Throws error', () => {
+      const stream = streamify();
+      assert.throws(() => {
+        stream.removeDest(streamify());
+      }, /destination stream has not been added/);
+    });
+  });
+
+});

test/pipe-test.js

@@ -17,8 +17,7 @@ describe('Pipe from a readable stream', () => {
     stream.pipe(writeStream);
 
     streamEqual(readStream, writeStream, (err, equal) => {
-      if (err) return done(err);
-
+      assert.ifError(err);
       assert.ok(equal);
       done();
     });
@@ -38,8 +37,7 @@ describe('Pipe to a writable stream', () => {
     fs.createReadStream(input, { bufferSize: 1024 }).pipe(stream);
 
     streamEqual(readStream, writeStream, (err, equal) => {
-      if (err) return done(err);
-
+      assert.ifError(err);
       assert.ok(equal);
       done();
     });
@@ -58,8 +56,7 @@ describe('Pipe to itself', () => {
     stream.pipe(stream);
 
     streamEqual(readStream, writeStream, (err, equal) => {
-      if (err) return done(err);
-
+      assert.ifError(err);
       assert.ok(equal);
       done();
     });

test/writable-test.js

@@ -3,12 +3,10 @@ const assert    = require('assert');
 const path      = require('path');
 const fs        = require('fs');
 
-const output1 = path.join(__dirname, 'files', 'output1.txt');
-const output2 = path.join(__dirname, 'files', 'output2.txt');
-
 
 describe('Create a writable stream', () => {
   it('Does not throw "write after end" error"', (done) => {
+    const output1 = path.join(__dirname, 'files', 'output1.txt');
     const stream = streamify({ readable: false });
     stream.resolve(fs.createWriteStream(output1));
     after((done) => fs.unlink(output1, done));
@@ -25,6 +23,7 @@ describe('Create a writable stream', () => {
   });
 
   it('Ends underlying write stream when streamify ends', (done) => {
+    const output2 = path.join(__dirname, 'files', 'output2.txt');
     const stream = streamify({ readable: false });
     stream.end('the only one');
 
@@ -35,4 +34,36 @@ describe('Create a writable stream', () => {
       ws.on('close', done);
     }, 50);
   });
+
+  describe('Add another destination after unresolving', () => {
+    it('Writes to both streams', (done) => {
+      const output3 = path.join(__dirname, 'files', 'output3.txt');
+      const output4 = path.join(__dirname, 'files', 'output4.txt');
+      const stream = streamify({ readable: false });
+
+      stream.resolve(fs.createWriteStream(output3));
+      after((done) => fs.unlink(output3, done));
+      stream.write('one\n');
+      stream.unresolve();
+
+      stream.resolve(fs.createWriteStream(output4));
+      after((done) => fs.unlink(output4, done));
+      stream.write('two!\n');
+      stream.end('end\n');
+
+      stream.on('finish', () => {
+        let n = 2;
+        fs.readFile(output3, 'utf8', (err, data) => {
+          assert.ifError(err);
+          assert.equal(data, 'one\n');
+          if (--n === 0) { done(); }
+        });
+        fs.readFile(output4, 'utf8', (err, data) => {
+          assert.ifError(err);
+          assert.equal(data, 'two!\nend\n');
+          if (--n === 0) { done(); }
+        });
+      });
+    });
+  });
 });