Skip to content

Does this package really need to require ECMAScript 2015? #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shawnlauzon opened this issue Apr 21, 2017 · 3 comments
Closed

Does this package really need to require ECMAScript 2015? #29

shawnlauzon opened this issue Apr 21, 2017 · 3 comments

Comments

@shawnlauzon
Copy link

This package uses the ... operator liberally, which means that users need to use a newer version of Node or Babel. Since feathers itself works on older versions of node, I'm wondering if this was a conscious decision on the part of the developers to support only newer versions?

At least, a warning should probably be added to the docs. I haven't yet created a PR for this because I wanted to start a conversation first.

@daffl
Copy link
Member

daffl commented Apr 21, 2017

All our packages are being compiled using Babel and then published which makes them compatible with Node 4+. If you want to use the cloned repository directly you will have to run npm run compile and then require files out of the lib/ folder. This is already done automatically when running npm test.

@daffl daffl closed this as completed Apr 21, 2017
@shawnlauzon
Copy link
Author

That's odd. You're right, as I look in the node_modules directory, there aren't any spread operators. But when I added it, my Node v4 server complained with SyntaxError: Unexpected token ... and the cloned repository didn't even exist on that node. Oh well, thanks for the response.

@eddyystop
Copy link
Collaborator

We push src/ to GitHub, and published lib/ on npm. Sometimes src/ is used to understand what is going on while debugging on lib/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants