Make a span as an error in OTEL

[piclemx]

Hello,

I was wondering what would be the recommended approach when using fastrace + opentelemetry to mark a span as an error.

In their documentation, you will use the span.setStatus(Error) and they have a function that does span.record(err).

What fastrace approach would be in that case?

[andylokandy]

OpenTelemetry defines error to be an event with proper attributes. Therefore, in fastrace, it's very straightforward to record an error like this:

LocalSpan::add_event(Event::new("exception")
    .with_property(|| ("exception.message", "Division by zero"))
    .with_property(|| ("exception.type", "OSError"))
    .with_property(|| ("exception.stacktrace", std::backtrace::Backtrace::force_capture().to_string()))
);

[piclemx]

Make senses.

@andylokandy I can reopen an issue but what about a SpanKind in the OTEL spec. I guess I could do the same kind of things. But i'm not sure that would be an attribute since I'm not finding in the spec. WDYT?

[andylokandy]

Currently, span kind is same across all spans in an application. It could be configured via fastrace-opentelemetry.

[piclemx]

Ok, but make it hards if I have span that needs to be Server coming from my http server and and I'm calling other services which theoretically needs to be Client.

[andylokandy]

yes... maybe fastrace-opentelemetry should be able to recognise it from specific attribute

[piclemx]

Could just with the span.kind attribute IMO. WDYT?

[andylokandy]

Could just with the span.kind attribute IMO. WDYT?

LGTM