fix(hmr): panic when call compiler.update for a full new module multi… (#2120)

fix(hmr): panic when call compiler.update for a full new module multiple times

Author: wre232114

.changeset/curvy-buttons-hug.md

@@ -0,0 +1,5 @@
+---
+"@farmfe/core": patch
+---
+
+Fix panic when call `compiler.update` for a full new module multiple times

crates/compiler/src/update/diff_and_patch_module_graph.rs

@@ -154,6 +154,13 @@ pub fn patch_module_graph(
 
   // add new modules first, as we need to add edges to them later
   for added in &diff_result.added_modules {
+    // if the added module is a start point, we should mark it as a new entry of the module graph
+    if start_points.contains(added) {
+      module_graph
+        .entries
+        .insert(added.clone(), added.to_string());
+    }
+
     let module = update_module_graph.take_module(added);
     module_graph.add_module(module);
   }

crates/compiler/src/update/patch_module_group_graph.rs

@@ -5,6 +5,7 @@ use farmfe_core::module::{
   module_group::{ModuleGroup, ModuleGroupGraph},
   Module, ModuleId,
 };
+use farmfe_plugin_partial_bundling::module_group_graph_from_entries;
 
 use super::diff_and_patch_module_graph::DiffResult;
 
@@ -18,6 +19,32 @@ pub fn patch_module_group_graph(
   let mut affected_module_groups = HashSet::new();
 
   for updated_module_id in &updated_module_ids {
+    // create new module group for the new entry
+    if diff_result.added_modules.contains(updated_module_id)
+      && module_graph.entries.contains_key(updated_module_id)
+    {
+      let mut added_module_group_graph =
+        module_group_graph_from_entries(&vec![updated_module_id.clone()], module_graph);
+      let edges = added_module_group_graph.edges();
+      let module_group_ids = added_module_group_graph
+        .module_groups()
+        .into_iter()
+        .map(|g| g.id.clone())
+        .collect::<Vec<_>>();
+
+      for module_group_id in module_group_ids {
+        if !module_group_graph.has(&module_group_id) {
+          let module_group = added_module_group_graph
+            .remove_module_group(&module_group_id)
+            .unwrap();
+          module_group_graph.add_module_group(module_group);
+        }
+      }
+
+      for (from, to) in edges {
+        module_group_graph.add_edge(&from, &to);
+      }
+    }
     let module = module_graph.module(updated_module_id).unwrap();
     let module_group_ids = module.module_groups.clone();
     affected_module_groups.extend(module_group_ids);

crates/core/src/module/module_group.rs

@@ -92,6 +92,19 @@ impl ModuleGroupGraph {
     self.g.node_weights().collect()
   }
 
+  pub fn edges(&self) -> Vec<(ModuleGroupId, ModuleGroupId)> {
+    self
+      .g
+      .edge_references()
+      .map(|edge| {
+        let source = self.g[edge.source()].id.clone();
+        let target = self.g[edge.target()].id.clone();
+
+        (source, target)
+      })
+      .collect()
+  }
+
   /// the same as [ModuleGroupGraph::module_groups], but mutable.
   pub fn module_groups_mut(&mut self) -> Vec<&mut ModuleGroup> {
     self.g.node_weights_mut().collect()