Skip to content

Commit 6b706f7

Browse files
author
Stefanni Brasil
authored
Freeze new generator and locales (#2886)
* Freeze new generator and locales As we discussed here https://github.com/orgs/faker-ruby/discussions/2877 we want to improve faker's performance and organization. There hasn't been to many bug reports and most of the open issues are related to performance and confusion around using faker. As we have limited time to invest in faker, reviewing new generators and locales take lots of our time. With this decision, we hope to make the necessary changes for faker to go to the next level. * Reinforce what contributors we will accept during the freeze
1 parent c7e5e46 commit 6b706f7

File tree

3 files changed

+4
-29
lines changed

3 files changed

+4
-29
lines changed

.github/ISSUE_TEMPLATE/feature-request.md

Lines changed: 0 additions & 22 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,9 @@ There are a few ways to run RuboCop:
8181

8282
## Adding new generators/locales
8383

84-
New generators will only be added to the gem after:
84+
The faker-ruby team has decided to stop accepting any new features, including generators and locales. Please see [What contributions we are looking for](#what-contributions-we-are-looking-for) for other ways you can help.
8585

86-
- there's been a poll in the [community](https://github.com/orgs/faker-ruby/discussions/categories/new-feature-locale-generator). Use this to get feedback on how others would use it, what edge cases to cover, etc.
87-
- the community is interested in the feature.
88-
89-
This allow us to measure the interest and see some traction before we decide to accept the proposal for a new generator.
90-
91-
**Note**: we will not accept new generators/locales that do not follow the requirements above.
86+
This allows us to focus on improving the performance and organization of the library. We appreciate your understanding and we are looking forward to get your help with making faker faster and easier to use.
9287

9388
### General Guidelines
9489

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,8 @@ gem 'faker', :git => 'https://github.com/faker-ruby/faker.git', :branch => 'main
479479

480480
## Contributing
481481

482+
**Note**: We are not accepting proposals for new generators and locales. The [Contributing](CONTRIBUTING.md) guide has a few notes about this decision.
483+
482484
Take a look at the [Contributing](CONTRIBUTING.md) document for
483485
instructions on setting up the repo on your machine, opening bug reports, understanding the codebase,
484486
and creating a good pull request.

0 commit comments

Comments
 (0)