Skip to content

Discrepancies with iban generation for PS and IE #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthewmayer opened this issue Apr 2, 2025 · 1 comment · Fixed by #3464
Closed

Discrepancies with iban generation for PS and IE #3463

matthewmayer opened this issue Apr 2, 2025 · 1 comment · Fixed by #3464
Assignees
@xDivisionByZerox
Labels
help wanted Extra attention is needed m: finance Something is referring to the finance module
Milestone
v9.x

Comments

@matthewmayer
Copy link
Contributor

Looks like there have been some changes to isIBAN in validator which cause failure

//[email protected]
validator.isIBAN("IE06 0192 5502 8613 0093 62") //true

//[email protected]
validator.isIBAN("IE06 0192 5502 8613 0093 62") //false

this is the fix in question https://github.com/validatorjs/validator.js/pull/2518/files

Originally posted by @matthewmayer in #3456 (comment)
@Shinigami92 Shinigami92 added help wanted Extra attention is needed m: finance Something is referring to the finance module labels Apr 2, 2025
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 2, 2025
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 2, 2025
@xDivisionByZerox xDivisionByZerox mentioned this issue Apr 2, 2025
Merged
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x Apr 2, 2025
@xDivisionByZerox
Copy link
Member

I moved the milestone to 9.x, since we usually do all dependency updates before a new release. If we want to do that, the issue need to be resolved before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
help wanted Extra attention is needed m: finance Something is referring to the finance module
Projects
None yet
Milestone
v9.x
Development

Successfully merging a pull request may close this issue.

fix(iban): more strict pattern for IE and PS faker-js/faker
3 participants
@matthewmayer @Shinigami92 @xDivisionByZerox