Adding a new locale without street_name definitions causes test failure

[matthewmayer]

Currently if you add a new locale with say just the person definitions, you get a test failure in

 FAIL  test/all_functional.spec.ts > functional tests > yo > location > streetName()
Error: The locale data for 'location.street_name' are missing in this locale.
  Please contribute the missing data to the project or use a locale/Faker instance that has these data.
  For more information see https://fakerjs.dev/guide/localization.html
 ❯ Object.get src/locale-proxy.ts:88:15
     86|         );
     87|       } else if (value === undefined) {
     88|         throw new FakerError(
       |               ^
     89|           `The locale data for '${categoryName}.${entryName.toString()}' are missing in this locale.
     90|   Please contribute the missing data to the project or use a locale/Faker instance that has these data.
 ❯ LocationModule.streetName src/modules/location/index.ts:228:39
 ❯ testAssertion test/all_functional.spec.ts:169:44

So either

1. you have to add a dummy street_name file like in feat(locale): add yo locale, start with person #2363
2. or add the new locale name to BROKEN_LOCALE_METHODS under location.streetName

Neither of these are particularly intuitive for a new contributor starting work on a new locale.

I'm not sure specifically why this method fails and not other methods in the location module?

[ST-DDT]

This likely caused by this:

faker/src/modules/location/index.ts

Lines 220 to 230 in 8e4ea67

	streetName(): string {
	deprecated({
	deprecated: 'faker.location.streetName',
	proposed: 'faker.location.street',
	since: '8.0',
	until: '9.0',
	});
	return this.faker.helpers.arrayElement(
	this.faker.definitions.location.street_name
	);
	}

In combination with it missing from en as fallback

faker/src/locales/en/location/index.ts

Lines 19 to 23 in 8e4ea67

	import state_abbr from './state_abbr';
	import street_address from './street_address';
	import street_pattern from './street_pattern';
	import street_suffix from './street_suffix';

[ST-DDT]

As a workaround we could temporarily provide a list for en.

[matthewmayer]

or set streetName: '*', in BROKEN_LOCALE_METHODS?

[ST-DDT]

There appears to be 19 files that contains these:
https://github.com/search?q=repo%3Afaker-js%2Ffaker+.%2Fstreet_name+path%3A%2F%5Esrc%5C%2Flocales%5C%2F%2F&type=code

[matthewmayer]

as the streetName() method is deprecated and these defintiions are now only used indirectly by street(), i think just changing the BROKEN_LOCALE_METHODS entry to streetName: '*', for the remainder of 8.x is the simplest solution to skip the checks.

[xDivisionByZerox]

I'll provide a PR implementing streetName in en_GB, en_US and en which will be represented as a combination from the 2 previous ones.

I'm a little confused why this has not been done so far.