Skip to content

Add pnpm run preflight command #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ST-DDT opened this issue Dec 6, 2022 · 7 comments · Fixed by #1846
Closed

Add pnpm run preflight command #1636

ST-DDT opened this issue Dec 6, 2022 · 7 comments · Fixed by #1846
Assignees
@xDivisionByZerox
Labels
c: feature Request for new feature c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Dec 6, 2022

Clear and concise description of the problem

Currently there are many steps that should be run before committing, but have to be run manually one after the other.

  • Formatting
  • Linting?
  • Update Test Snapshots
  • Run Tests
  • Generate Locales
  • Generate Api-Docs

Suggested solution

Introduce a command that runs all those commands using a single command. e.g. pnpn run dev:complete

Alternative

No response

Additional context

No response
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: infra Changes to our infrastructure or project setup labels Dec 6, 2022
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Dec 6, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 6, 2022

Partially blocked by: #1635

@Shinigami92 Shinigami92 changed the title Add pnpn run dev:complete command Add pnpm run dev:complete command Dec 6, 2022
@matthewmayer
Copy link
Contributor

as a relatively new contributor i would like this! Easy to forget a step

@matthewmayer
Copy link
Contributor

i would vote for a catchier name though. like pnpm run checks or pnpm run preflight or pnpm run checklist or something like that.

@ejcheng
Copy link
Member

ejcheng commented Dec 19, 2022

i would vote for a catchier name though. like pnpm run checks or pnpm run preflight or pnpm run checklist or something like that.

preflight sounds cool

@matthewmayer matthewmayer mentioned this issue Dec 26, 2022
Merged
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 16, 2023
@xDivisionByZerox xDivisionByZerox moved this from Todo to In Progress in Faker Roadmap Feb 16, 2023
@xDivisionByZerox xDivisionByZerox mentioned this issue Feb 16, 2023
Merged
@xDivisionByZerox
Copy link
Member

I'll move the needs decision label from here into the PR #1846 itself.

@xDivisionByZerox xDivisionByZerox removed the s: needs decision Needs team/maintainer decision label Feb 16, 2023
@xDivisionByZerox xDivisionByZerox linked a pull request Feb 16, 2023 that will close this issue
infra: add preflight script #1846
Merged
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Feb 16, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 16, 2023

Team Decision

We will name this command preflight.

@ST-DDT ST-DDT changed the title Add pnpm run dev:complete command Add pnpm run preflight command Feb 16, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap Feb 18, 2023
@Shinigami92
Copy link
Member

Shinigami92 commented Feb 21, 2023 •
edited
Loading

I started to use this command and when switching branches the pnpm install makes now a ton of sense 👍
I like it

I just also do git switch X -> git pull --rebase -> pnpm run preflight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: feature Request for new feature c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

infra: add preflight script faker-js/faker
5 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox