Skip to content

Change number.int default max to Number.MAX_SAFE_INTEGER #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shinigami92 opened this issue Nov 24, 2022 · 1 comment · Fixed by #1643
Closed

Change number.int default max to Number.MAX_SAFE_INTEGER #1598

Shinigami92 opened this issue Nov 24, 2022 · 1 comment · Fixed by #1643
Assignees
@Shinigami92
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@Shinigami92
Copy link
Member

We want that the number.int max value is by default Number.MAX_SAFE_INTEGER

We are open for other proposed min or max values

This wont affect legacy datatype.number!

Waiting on:
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module labels Nov 24, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Nov 24, 2022
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Nov 24, 2022
@Shinigami92
Copy link
Member Author

Team Decision:
Yes lets do Number.MAX_SAFE_INTEGER

@Shinigami92 Shinigami92 removed the s: needs decision Needs team/maintainer decision label Nov 24, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 24, 2022
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Dec 7, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 9, 2022
@Shinigami92 Shinigami92 mentioned this issue Dec 9, 2022
Merged
@Shinigami92 Shinigami92 moved this from Todo to Awaiting Review in Faker Roadmap Dec 9, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Dec 17, 2022
@dephiros dephiros mentioned this issue May 24, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

feat(number)!: change int default params faker-js/faker
2 participants
@ST-DDT @Shinigami92