Skip to content

Reduce dependency update PRs to once a week #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ST-DDT opened this issue Aug 16, 2022 · 3 comments · Fixed by #1302
Closed

Reduce dependency update PRs to once a week #1275

ST-DDT opened this issue Aug 16, 2022 · 3 comments · Fixed by #1302
Assignees
@xDivisionByZerox
Labels
c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Milestone
v7 - Current Major

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Aug 16, 2022 •
edited
Loading

Clear and concise description of the problem

Currently we are spammed by dependency update PRs that mostly add noise to the commit history.

Suggested solution

Change the daily check to weekly.
I prefer early Monday mornings for this, so we have enough time to review and merge them before our usual releases on some Mondays.

Alternative

Switch to an on demand update check.

Additional context

No response
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency s: needs decision Needs team/maintainer decision c: infra Changes to our infrastructure or project setup labels Aug 16, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 16, 2022
@ejcheng
Copy link
Member

ejcheng commented Aug 16, 2022

I agree with switching the daily check to weekly, it gets tedious having to sift through all of the dependency PRs.

@Shinigami92
Copy link
Member

For a written down comment: I tend to say yes, but => next Team Meeting

@xDivisionByZerox xDivisionByZerox linked a pull request Aug 26, 2022 that will close this issue
infra: set renovate schedule to weekly #1302
Merged
@xDivisionByZerox
Copy link
Member

This has been fixed in #1302

@xDivisionByZerox xDivisionByZerox removed the s: needs decision Needs team/maintainer decision label Aug 26, 2022
@xDivisionByZerox xDivisionByZerox self-assigned this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging a pull request may close this issue.

infra: set renovate schedule to weekly faker-js/faker
4 participants
@ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox