Skip to content

Commit ef6fbac

Browse files
ST-DDTST-DDT
authored
chore: deprecate address.streetPrefix and suffix (#1053)
1 parent aedd7b8 commit ef6fbac

File tree

20 files changed

+68
-49
lines changed

20 files changed

+68
-49
lines changed

‎src/locales/af_ZA/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/de_CH/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/el/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_AU/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_CA/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_GB/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_IE/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_IND/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_NG/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_US/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/en_ZA/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/fr_CA/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/ne/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/pt_BR/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/vi/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/locales/zu_ZA/address/street.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{name.firstName}} {{address.streetSuffix}}',
3-
'{{name.lastName}} {{address.streetSuffix}}',
2+
'{{name.firstName}} {{address.street_suffix}}',
3+
'{{name.lastName}} {{address.street_suffix}}',
44
];

‎src/modules/address/index.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,20 @@ export class Address {
218218
/**
219219
* Returns a random localized street suffix.
220220
*
221+
* @see faker.address.street
222+
*
221223
* @example
222224
* faker.address.streetSuffix() // 'Streets'
225+
*
226+
* @deprecated Use faker.address.street() instead.
223227
*/
224228
streetSuffix(): string {
229+
deprecated({
230+
deprecated: 'faker.address.streetSuffix()',
231+
proposed: 'faker.address.street()',
232+
since: '7.4',
233+
until: '8.0',
234+
});
225235
return this.faker.helpers.arrayElement(
226236
this.faker.definitions.address.street_suffix
227237
);
@@ -230,10 +240,20 @@ export class Address {
230240
/**
231241
* Returns a random localized street prefix.
232242
*
243+
* @see faker.address.street
244+
*
233245
* @example
234246
* fakerGH.address.streetPrefix() // 'Boame'
247+
*
248+
* @deprecated Use faker.address.street() instead.
235249
*/
236250
streetPrefix(): string {
251+
deprecated({
252+
deprecated: 'faker.address.streetPrefix()',
253+
proposed: 'faker.address.street()',
254+
since: '7.4',
255+
until: '8.0',
256+
});
237257
return this.faker.helpers.arrayElement(
238258
this.faker.definitions.address.street_prefix
239259
);

‎src/modules/random/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ export class Random {
129129
this.faker.company.bsAdjective,
130130
this.faker.company.bsBuzz,
131131
this.faker.company.bsNoun,
132-
this.faker.address.streetSuffix,
133132
this.faker.address.county,
134133
this.faker.address.country,
135134
this.faker.address.state,

‎test/__snapshots__/random.spec.ts.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ exports[`random > 42 > numeric > noArgs 1`] = `"4"`;
1414

1515
exports[`random > 42 > numeric > withLength 1`] = `"47917"`;
1616

17-
exports[`random > 42 > word 1`] = `"extend"`;
17+
exports[`random > 42 > word 1`] = `"impactful"`;
1818

1919
exports[`random > 42 > words > noArgs 1`] = `"mobile Fish"`;
2020

21-
exports[`random > 42 > words > withLength 1`] = `"extend Directives application Home Dam"`;
21+
exports[`random > 42 > words > withLength 1`] = `"impactful Directives transmit Home initiatives"`;
2222

2323
exports[`random > 1211 > alpha > noArgs 1`] = `"y"`;
2424

@@ -36,9 +36,9 @@ exports[`random > 1211 > numeric > withLength 1`] = `"94872"`;
3636

3737
exports[`random > 1211 > word 1`] = `"Division"`;
3838

39-
exports[`random > 1211 > words > noArgs 1`] = `"Turnpike Frozen Handcrafted"`;
39+
exports[`random > 1211 > words > noArgs 1`] = `"functionalities Frozen Baby"`;
4040

41-
exports[`random > 1211 > words > withLength 1`] = `"Division Forward Supervisor Peso ivory"`;
41+
exports[`random > 1211 > words > withLength 1`] = `"Division Forward purple Supervisor Peso"`;
4242

4343
exports[`random > 1337 > alpha > noArgs 1`] = `"g"`;
4444

@@ -54,8 +54,8 @@ exports[`random > 1337 > numeric > noArgs 1`] = `"3"`;
5454

5555
exports[`random > 1337 > numeric > withLength 1`] = `"35122"`;
5656

57-
exports[`random > 1337 > word 1`] = `"leading"`;
57+
exports[`random > 1337 > word 1`] = `"Organic"`;
5858

5959
exports[`random > 1337 > words > noArgs 1`] = `"Delaware"`;
6060

61-
exports[`random > 1337 > words > withLength 1`] = `"leading black Kiribati Garden Indiana"`;
61+
exports[`random > 1337 > words > withLength 1`] = `"Organic Bike interactive core Montenegro"`;

‎test/__snapshots__/system.spec.ts.snap

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports[`system > 42 > fileName > noArgs 1`] = `"mobile_fish.jxsc"`;
1818

1919
exports[`system > 42 > fileName > with extensionCount 1`] = `"mobile_fish.jxsc.jardiff"`;
2020

21-
exports[`system > 42 > filePath 1`] = `"/opt/bin/directives_application_home.ptid"`;
21+
exports[`system > 42 > filePath 1`] = `"/opt/bin/directives_transmit_home.ptid"`;
2222

2323
exports[`system > 42 > fileType 1`] = `"image"`;
2424

@@ -28,9 +28,9 @@ exports[`system > 42 > semver 1`] = `"3.7.9"`;
2828

2929
exports[`system > 1211 > commonFileExt 1`] = `"htm"`;
3030

31-
exports[`system > 1211 > commonFileName > noArgs 1`] = `"turnpike_frozen_handcrafted.mp4v"`;
31+
exports[`system > 1211 > commonFileName > noArgs 1`] = `"functionalities_frozen_baby.m2a"`;
3232

33-
exports[`system > 1211 > commonFileName > with extension 1`] = `"turnpike_frozen_handcrafted.ext"`;
33+
exports[`system > 1211 > commonFileName > with extension 1`] = `"functionalities_frozen_baby.ext"`;
3434

3535
exports[`system > 1211 > commonFileType 1`] = `"application"`;
3636

@@ -40,11 +40,11 @@ exports[`system > 1211 > fileExt > noArgs 1`] = `"dic"`;
4040

4141
exports[`system > 1211 > fileExt > with mimeType 1`] = `"map"`;
4242

43-
exports[`system > 1211 > fileName > noArgs 1`] = `"turnpike_frozen_handcrafted.heifs"`;
43+
exports[`system > 1211 > fileName > noArgs 1`] = `"functionalities_frozen_baby.tsd"`;
4444

45-
exports[`system > 1211 > fileName > with extensionCount 1`] = `"turnpike_frozen_handcrafted.heifs.oth"`;
45+
exports[`system > 1211 > fileName > with extensionCount 1`] = `"functionalities_frozen_baby.tsd.xml"`;
4646

47-
exports[`system > 1211 > filePath 1`] = `"/var/log/forward_supervisor.z2"`;
47+
exports[`system > 1211 > filePath 1`] = `"/var/log/forward_purple.avi"`;
4848

4949
exports[`system > 1211 > fileType 1`] = `"x-shader"`;
5050

@@ -90,7 +90,7 @@ exports[`system > seed: 42 > fileExt() 1`] = `"lrm"`;
9090

9191
exports[`system > seed: 42 > fileName() 1`] = `"mobile_fish.jxsc"`;
9292

93-
exports[`system > seed: 42 > filePath() 1`] = `"/opt/bin/directives_application_home.ptid"`;
93+
exports[`system > seed: 42 > filePath() 1`] = `"/opt/bin/directives_transmit_home.ptid"`;
9494

9595
exports[`system > seed: 42 > fileType() 1`] = `"image"`;
9696

@@ -100,17 +100,17 @@ exports[`system > seed: 42 > semver() 1`] = `"3.7.9"`;
100100

101101
exports[`system > seed: 1211 > commonFileExt() 1`] = `"htm"`;
102102

103-
exports[`system > seed: 1211 > commonFileName() 1`] = `"turnpike_frozen_handcrafted.mp4v"`;
103+
exports[`system > seed: 1211 > commonFileName() 1`] = `"functionalities_frozen_baby.m2a"`;
104104

105105
exports[`system > seed: 1211 > commonFileType() 1`] = `"application"`;
106106

107107
exports[`system > seed: 1211 > directoryPath() 1`] = `"/var/log"`;
108108

109109
exports[`system > seed: 1211 > fileExt() 1`] = `"dic"`;
110110

111-
exports[`system > seed: 1211 > fileName() 1`] = `"turnpike_frozen_handcrafted.heifs"`;
111+
exports[`system > seed: 1211 > fileName() 1`] = `"functionalities_frozen_baby.tsd"`;
112112

113-
exports[`system > seed: 1211 > filePath() 1`] = `"/var/log/forward_supervisor.z2"`;
113+
exports[`system > seed: 1211 > filePath() 1`] = `"/var/log/forward_purple.avi"`;
114114

115115
exports[`system > seed: 1211 > fileType() 1`] = `"x-shader"`;
116116

0 commit comments

Comments
 (0)