Skip to content

Commit e29e875

Browse files
authored
build: add node v18 support (#847)
1 parent 18614fb commit e29e875

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

.github/workflows/ci.yml

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,16 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [ubuntu-latest]
15-
node_version: [14, 16, 17]
15+
node_version: [14, 16, 18]
1616
include:
1717
- os: macos-latest
1818
node_version: 16
19+
- os: macos-latest
20+
node_version: 18
1921
- os: windows-latest
2022
node_version: 16
23+
- os: windows-latest
24+
node_version: 18
2125
fail-fast: false
2226

2327
name: 'Build & Unit Test: node-${{ matrix.node_version }}, ${{ matrix.os }}'
@@ -49,7 +53,7 @@ jobs:
4953

5054
e2e-test:
5155
runs-on: ubuntu-latest
52-
name: 'E2E Doc Test: node-16, ubuntu-latest'
56+
name: 'E2E Doc Test: node-18, ubuntu-latest'
5357
steps:
5458
- name: Checkout
5559
uses: actions/checkout@v3
@@ -59,6 +63,12 @@ jobs:
5963
with:
6064
version: 7
6165

66+
- name: Set node version to 18
67+
uses: actions/setup-node@v3
68+
with:
69+
node-version: 18
70+
cache: 'pnpm'
71+
6272
- name: Install deps
6373
run: pnpm install
6474

@@ -67,7 +77,7 @@ jobs:
6777

6878
lint:
6979
runs-on: ubuntu-latest
70-
name: 'Lint: node-16, ubuntu-latest'
80+
name: 'Lint: node-18, ubuntu-latest'
7181
steps:
7282
- name: Checkout
7383
uses: actions/checkout@v3
@@ -79,10 +89,10 @@ jobs:
7989
with:
8090
version: 7
8191

82-
- name: Set node version to 16
92+
- name: Set node version to 18
8393
uses: actions/setup-node@v3
8494
with:
85-
node-version: 16
95+
node-version: 18
8696
cache: 'pnpm'
8797

8898
- name: Install deps
@@ -98,7 +108,7 @@ jobs:
98108

99109
codecov:
100110
runs-on: ubuntu-latest
101-
name: 'Codecov: node-16, ubuntu-latest'
111+
name: 'Codecov: node-18, ubuntu-latest'
102112
steps:
103113
- name: Checkout
104114
uses: actions/checkout@v3
@@ -110,10 +120,10 @@ jobs:
110120
with:
111121
version: 7
112122

113-
- name: Set node version to 16
123+
- name: Set node version to 18
114124
uses: actions/setup-node@v3
115125
with:
116-
node-version: 16
126+
node-version: 18
117127
cache: 'pnpm'
118128

119129
- name: Install deps

netlify.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[build.environment]
2-
NODE_VERSION = "16"
2+
NODE_VERSION = "18"
33
NPM_FLAGS = "--version" # prevent Netlify npm install
44

55
# Documentation

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
},
9191
"devDependencies": {
9292
"@types/markdown-it": "~12.2.3",
93-
"@types/node": "~16.11.33",
93+
"@types/node": "~17.0.31",
9494
"@types/prettier": "~2.6.0",
9595
"@types/sanitize-html": "~2.6.2",
9696
"@types/validator": "~13.7.2",

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)